- Notifications
You must be signed in to change notification settings - Fork242
fix: replace use of deprecated methods#1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
3c12c98 tof72605cCompare| @@ -19,6 +19,32 @@ declare module '@typescript-eslint/utils/dist/ts-eslint/Rule' { | |||
| } | |||
| } | |||
| declare module '@typescript-eslint/utils/dist/ts-eslint/SourceCode' { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can we avoid this by upgrading to v6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah I implemented the types intypescript-eslint/typescript-eslint#7812
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sweet! we should probably do that in a major
| @@ -229,3 +229,63 @@ export const getFirstMatcherArg = ( | |||
| return followTypeAssertionChain(firstArg); | |||
| }; | |||
| /* istanbul ignore next */ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why do we need to ignore coverage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
because only one branch in each function should ever get used depending on what ESLint version you're using, and coverage is only collected against a single ESLint version at a time (technically we could merge reports for CI but that'd still be a pain locally)
SimenB left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
woo!
should we set up CI to test against v9?
Yup, though I'll do that in a follow-up PR |
## [27.6.3](v27.6.2...v27.6.3) (2024-01-12)### Bug Fixes* replace use of deprecated methods ([#1453](#1453)) ([9204a51](9204a51))
🎉 This PR is included in version 27.6.3 🎉 The release is available on: Yoursemantic-release bot 📦🚀 |
Perhttps://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/
Marking as a draft for now since there isn't an immediate need to land this and I want to dig a bit deeper into ESLint v9 etc in case there are other deprecations that might be upcoming.