- Notifications
You must be signed in to change notification settings - Fork687
Remove deprecated enum conversions#5207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
kasperisager wants to merge1 commit intojerryscript-project:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Remove deprecated enum conversions#5207
kasperisager wants to merge1 commit intojerryscript-project:masterfromkasperisager:fix-enum-conversion
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Implicit enum conversion was deprecated in C++20 with the result thatJerryScript doesn't compile in newer versions of Clang, in my case LLVM20. This patch removes implicit enum conversions and instead performsexplicit casts.JerryScript-DCO-1.0-Signed-off-by: Kasper Isager Dalsgarð <kasperisager@hey.com>
Author
kasperisager commentedMar 29, 2025
Is there anything I can do to help land this? |
zherczeg approved these changesMar 29, 2025
Member
zherczeg left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Author
kasperisager commentedJun 26, 2025
I'm hitting this on quite a few systems now, including macOS and Linux. A second review so this can land would be much appreciated! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implicit enum conversion was deprecated in C++20 with the result that JerryScript doesn't compile in newer versions of Clang, in my case LLVM 20. This patch removes implicit enum conversions and instead performs explicit casts.