- Notifications
You must be signed in to change notification settings - Fork684
Implement jerry_port_path_normalize in a more reliable way#5198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
lygstate wants to merge1 commit intojerryscript-project:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
9714443 to2223363CompareReplace jerry_port_path_normalize,jerry_port_path_free,jerry_port_path_base with jerry_port_path_style,jerry_port_get_cwdPartiallyfixesjerryscript-project#4979Closes:jerryscript-project#4983JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace jerry_port_path_normalize,jerry_port_path_free,jerry_port_path_base with jerry_port_path_style,jerry_port_get_cwd
Partiallyfixesfeature, strlen are rarely called in jerry-core and jerry-ext, we can remove all the usage of strlen #4979
Closes:on unix, realpath are can failed when the path not exist #4983
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luoluoyonggang@gmail.com
now fore memory-restricted system, excluding es-module will reduce code size
The port api is reduced to simpler
jerry_port_path_stylejerry_port_get_cwd