- Notifications
You must be signed in to change notification settings - Fork687
Update API version to 2.1.0.#3220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Update API version to 2.1.0.#3220
Uh oh!
There was an error while loading.Please reload this page.
Conversation
akosthekiss left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minor comment: IMHO "Closes#3104" would look better in the commit message, as the referenced issue is not a bug to be fixed.
f08146c tod42cff2Compareossy-szeged commentedOct 16, 2019
Good point, I fixed the commit message. |
Closesjerryscript-project#3104.JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonác oszi@inf.u-szeged.hu
d42cff2 toe35abc5Compare
rerobika left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
dbatyai left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Uh oh!
There was an error while loading.Please reload this page.
Closes#3104.
JerryScript-DCO-1.0-Signed-off-by: Csaba Osztrogonácoszi@inf.u-szeged.hu