NotificationsYou must be signed in to change notification settings
Fork126
Star1.5k

fix(Response/type): resolve void returned instead of this#181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

naorpeled merged 1 commit intojeremydaly:mainfromcodyfyi:patch-1

Jan 1, 2023

Merged

fix(Response/type): resolve void returned instead of this#181

naorpeled merged 1 commit intojeremydaly:mainfromcodyfyi:patch-1

Jan 1, 2023

Conversation

Copy link

Contributor

codyfyi commentedMay 28, 2021

It is valid to chainresponse.type('application/xml').status(200).send(xml) because thetype function returns an instance ofthis. This change correct theindex.d.ts typing description from incorrectly returningvoid to correctly returningthis as apparent fromlib/response.js .

Fix typing for Response#type function.

d0fa565

It is valid to chain `response.type('application/xml').status(200).send(xml)` because the `type` function returns an instance of **this**. This change correct the `index.d.ts` typing description from incorrectly returning **void** to correctly returning **this** as apparent from `lib/response.js` .