Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Attempt on"fix" active-choices-plugin#444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
molnare wants to merge11 commits intojenkinsci:master
base:master
Choose a base branch
Loading
frommolnare:master

Conversation

@molnare
Copy link

UnoChoice.es6

ReferencedParameter

  • updates every cascadeParameter referencing itself

getParameterValue

Reworked the whole function. It needs review!

renderCascadeChoiceParameter & renderDynamicRenderParameter

  • changed the way the input text box is identified
  • added the ordered and unordered list
  • the function now triggers an update on all cascadeParameters

Refactored prototypes to classes:

  • CascadeParameter
  • ReferencedParameter
  • DynamicReferenceParameter
  • FilterElement

@molnaremolnare requested a review froma team as acode ownerMarch 3, 2025 16:41
Add support for retrieving values from custom input fields with the "value" attribute in specific HTML formats. This ensures proper handling of these inputs alongside existing radio button and text processing logic.
Copy link
Member

@kinowkinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@molnare ! I think it has a lot of things that could be merged to improve the code, but that are not really fixing the plug-in. The refactoring is nice, but it'll be easier to review it later.

I'll see if I can fix it too, and I will compare what I did with yours and#357 .

molnare reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kinowkinowkinow left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@molnare@kinow@msg-molnare

[8]ページ先頭

©2009-2025 Movatter.jp