Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: fix for tests#603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ekynoxe
Copy link

@ekynoxeekynoxe commentedOct 5, 2023•
edited
Loading

Browser tests are filing as the bundle file Karma tries to load is not found and frontend tests fail to even start.

It looks like the issue was introduced by#516 and I'm not sure what it aimed to solve since the esbuild generated file is bundle.esm.js, whilst the webpack one was bundle-esm.js (simply bundle.js with this PR.)

I think the file rename was unnecessary, so I've reverted that.

We could also update the karma configuration file to use bundle-esm.js, it fixes the browser tests as well.

There seems to be a process to publish the module that renames the bundle-esm.js file to bundle.js. I don't know why we need to name the webpack generated file with the -esm suffix.
@ekynoxeekynoxeforce-pushed thefix/bundle-file-for-tests branch from5ba1970 tof62bdd3CompareOctober 5, 2023 11:12
@ekynoxeekynoxe mentioned this pull requestOct 5, 2023
@steveoni
Copy link
Member

@ekynoxe did you also check if it fix this issue#514 as suggested by#516

@ekynoxe
Copy link
Author

@steveoni for me, when linking danfojs from a new vue app, master doesn't work. I get the same error describe in#594 .
So this particular PR doesn't fix#514, but my PR#604 does. I'll update the description that it also works with a new Vuew project.

Screenshot 2023-10-09 at 09 31 54

@rchavp
Copy link

Has anyone figured out how to fix this issue? I was really looking forward to using this library in our production pipeline, but I can't remove Vite unfortunately and local hacks/fixes are a no go either.

@ekynoxe
Copy link
Author

Has anyone figured out how to fix this issue? I was really looking forward to using this library in our production pipeline, but I can't remove Vite unfortunately and local hacks/fixes are a no go either.

I'm afraid we've had zero feedback from the maintainers on either of my PRs, so we can't do much anymore.

@risenW
Copy link
Member

risenW commentedApr 2, 2025•
edited
Loading

Sorry for the delay here, this has been fixed. So closing this PR Ignore, wrong PR

@risenWrisenW closed thisApr 2, 2025
@risenWrisenW reopened thisApr 2, 2025
@risenWrisenW merged commit2da0e48 intojavascriptdata:devApr 2, 2025
0 of 2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ekynoxe@steveoni@rchavp@risenW
[8]ページ先頭
©2009-2025 Movatter.jp