javascript-tutorial/vi.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork44
Star40

Coding Style#174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tunggnu merged 25 commits intojavascript-tutorial:masterfromImVietnam:patch-2

Jun 8, 2023

Merged

Coding Style#174

tunggnu merged 25 commits intojavascript-tutorial:masterfromImVietnam:patch-2

Jun 8, 2023

Conversation

Copy link

Contributor

ImVietnam commentedFeb 21, 2023

No description provided.

Update article.md

9bad668

javascript-translate-bot added the review needed label

Feb 21, 2023

javascript-translate-bot requested a review froma team

February 21, 2023 14:47

javascript-translate-bot mentioned this pull request

Feb 21, 2023

Vietnamese Translation Progress#1

Open

ImVietnam added14 commits

February 22, 2023 09:58

Update code-style.svg

73b0c53

Update code-style.svg

8e42191

Update code-style.svg

25c1521

Update code-style.svg

f1a0a9d

Update code-style.svg

e5e830a

Update code-style.svg

8899520

Update code-style.svg

fa1734b

Update code-style.svg

7368691

Update code-style.svg

185584c

Merge pull request#2from ImVietnam/patch-4

6e7a504

Patch 4

Update article.md

631b353

Update task.md

b44d40c

Update solution.md

e6080c4

Merge pull request#3from ImVietnam/patch-4

ab3fc90

Patch 4

henryonsoftware suggested changes

Feb 23, 2023

View reviewed changes

1-js/03-code-quality/02-coding-style/1-style-errors/solution.md OutdatedShow resolvedHide resolved

1-js/03-code-quality/02-coding-style/1-style-errors/task.md OutdatedShow resolvedHide resolved

1-js/03-code-quality/02-coding-style/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

Feb 23, 2023

Copy link

javascript-translate-bot commentedFeb 23, 2023

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

ImVietnam added3 commits

February 25, 2023 13:03

Update solution.md

7787c62

Update task.md

1375bf1

Update article.md

7da2573

Copy link

ContributorAuthor

ImVietnam commentedFeb 25, 2023

/done

javascript-translate-bot added review needed and removed changes requested labels

Feb 25, 2023

javascript-translate-bot requested a review froma team

February 25, 2023 06:20

henryonsoftware removed the review needed label

Feb 28, 2023

henryonsoftware added the changes requested label

Feb 28, 2023

Update article.md

87d1b13

Copy link

ContributorAuthor

ImVietnam commentedMar 1, 2023

/done

javascript-translate-bot added review needed and removed changes requested labels

Mar 1, 2023

henryonsoftware approved these changes

Mar 1, 2023

View reviewed changes

Copy link

Contributor

henryonsoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

javascript-translate-bot added needs +1 and removed review needed labels

Mar 1, 2023

henryonsoftware requested a review fromtunggnu

March 1, 2023 19:25

Merge branch 'javascript-tutorial:master' into patch-2

6c7aaae

tunggnu requested changes

Jun 8, 2023

View reviewed changes

1-js/03-code-quality/02-coding-style/1-style-errors/solution.md OutdatedShow resolvedHide resolved

1-js/03-code-quality/02-coding-style/1-style-errors/task.md OutdatedShow resolvedHide resolved

1-js/03-code-quality/02-coding-style/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot added the changes requested label

Jun 8, 2023

Copy link

javascript-translate-bot commentedJun 8, 2023

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

ImVietnam added4 commits

June 8, 2023 12:26

Update solution.md

b41d273

Update task.md

b05925b

Update article.md

1b00f35

Update article.md

3b73fe3

Copy link

ContributorAuthor

ImVietnam commentedJun 8, 2023

/done

javascript-translate-bot added review needed and removed changes requested labels

Jun 8, 2023

javascript-translate-bot requested a review froma team

June 8, 2023 05:30

Merge branch 'javascript-tutorial:master' into patch-2

917bbe5

tunggnu approved these changes

Jun 8, 2023

View reviewed changes

Copy link

Contributor

tunggnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good

tunggnu merged commit94a73bd intojavascript-tutorial:master

Jun 8, 2023

Copy link

javascript-translate-bot commentedJun 8, 2023

Thank you 💖 I updated the Progress Issue#1 🎉 🎉 🎉

Labels

needs +1 review needed

Movatterモバイル変換

Coding Style#174

Coding Style#174

Uh oh!

Conversation

ImVietnam commentedFeb 21, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedFeb 23, 2023

Uh oh!

ImVietnam commentedFeb 25, 2023

Uh oh!

ImVietnam commentedMar 1, 2023

Uh oh!

henryonsoftware left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedJun 8, 2023

Uh oh!

ImVietnam commentedJun 8, 2023

Uh oh!

tunggnu left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commentedJun 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants