Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Coding style#59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tarasyyyk merged 27 commits intojavascript-tutorial:masterfromalexgalkin:master
Feb 27, 2020
Merged

Conversation

alexgalkin
Copy link
Contributor

Another attempt to prepare PR for translation (as mentioned previously SVG will be changed using YAML file later). Please review and comment.

Copy link
Collaborator

@tarasyyyktarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very good translation!
Please, made small corrections and I'll merge this PR.


Our code must be as clean and easy to read as possible.
Наш код повинен бути настільки чистим та зрозумілим наскільки це можливо.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

«настільки зрозумілим та читабельним, наскільки це можливо»

@@ -34,15 +34,15 @@ if (n < 0) {

-->

Now let's discuss the rules and reasons for them in detail.
Давайте розберемо ці правила і причини їх з'явлення більш детально.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

«Давайте детальніше розглянемо ці правила і причини їх появи»

@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

alexgalkinand others added10 commitsFebruary 27, 2020 00:14
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin
Copy link
ContributorAuthor

/done

Copy link
Collaborator

@tarasyyyktarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The last small correction need to be fixed before merge.

@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Copy link
Collaborator

@tarasyyyktarasyyyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great job! Thank you for contribution!

@tarasyyyktarasyyyk merged commitc792b67 intojavascript-tutorial:masterFeb 27, 2020
@tarasyyyktarasyyyk changed the titleTranslate Code Style sectionCoding styleAug 29, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tarasyyyktarasyyyktarasyyyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@alexgalkin@javascript-translate-bot@tarasyyyk
[8]ページ先頭
©2009-2025 Movatter.jp