javascript-tutorial/uk.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork184
Star366

Drag'n'Drop with mouse events#322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dolgachio merged 13 commits intojavascript-tutorial:masterfromAntonBurchak:drag-n-drop

Mar 26, 2022

Merged

Drag'n'Drop with mouse events#322

dolgachio merged 13 commits intojavascript-tutorial:masterfromAntonBurchak:drag-n-drop

Mar 26, 2022

Conversation

Copy link

Contributor

AntonBurchak commentedFeb 23, 2022

No description provided.

Anton_Burchakand others added3 commits

December 13, 2021 20:17

Finished translate "Dynamic imports" article

833a6cd

Revert "Finished translate "Dynamic imports" article"

b4158fc

This reverts commit833a6cd.

added some translations and provided corrections

c843f3d

javascript-translate-bot added the review needed label

Feb 23, 2022

javascript-translate-bot mentioned this pull request

Feb 23, 2022

Ukrainian Translation Progress#1

Open

Copy link

CLAassistant commentedFeb 23, 2022

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign ourContributor License Agreement before we can accept your contribution.
1 out of2 committers have signed the CLA.

✅ AntonBurchak
❌ Anton_Burchak

Anton_Burchak seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let usrecheck it.}

Copy link

ContributorAuthor

AntonBurchak commentedFeb 23, 2022

@tarasyyyk Можеш будь-ласка подивитись?)

Copy link

Collaborator

dolgachio commentedMar 13, 2022

@AntonBurchak привіт, для комітів у цьому пулл реквесті ви використала два різні аккаунти:
✅ AntonBurchak
❌ Anton_Burchak
Для того, щоб ми могли прийняти пулл реквест, потрібно додати другого користувача до вашого GitHub аккаунту

dolgachio added the in progressTranslation in progress label

Mar 13, 2022

dolgachio self-requested a review

March 13, 2022 22:23

dolgachio requested changes

Mar 21, 2022

View reviewed changes

Copy link

Collaborator

dolgachio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Дякую за чудовий переклад! Будя ласка, подивіться на мої коментарі.
Звертаю вашу увагу, що я ще не закінчиві переверку, завершу сьогодні ;)

2-ui/3-event-details/4-mouse-drag-and-drop/1-slider/solution.md OutdatedShow resolvedHide resolved

2-ui/3-event-details/4-mouse-drag-and-drop/1-slider/task.md OutdatedShow resolvedHide resolved

2-ui/3-event-details/4-mouse-drag-and-drop/1-slider/solution.md OutdatedShow resolvedHide resolved

2-ui/3-event-details/4-mouse-drag-and-drop/1-slider/solution.view/index.html OutdatedShow resolvedHide resolved

2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/solution.md OutdatedShow resolvedHide resolved

2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/solution.view/soccer.js OutdatedShow resolvedHide resolved

2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/source.view/index.html Outdated


		<p>And one more thing: heroes may never leave the page. If they reach the edge of the document, no dragging outside of it.</p>

		<h2>Розставте супергероїв по полю.</h2>

Copy link

Collaborator

dolgachioMar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Будь ласка, змініть цей файл, відповідно до моїх коменьтарів вище

2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/solution.view/index.html OutdatedShow resolvedHide resolved

2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/task.md OutdatedShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

Mar 21, 2022

Copy link

Contributor

javascript-translate-bot commentedMar 21, 2022

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

dolgachio added the partially reviewed label

Mar 21, 2022

dolgachio requested changes

Mar 21, 2022

View reviewed changes

2-ui/3-event-details/4-mouse-drag-and-drop/article.md OutdatedShow resolvedHide resolved

Copy link

Contributor

javascript-translate-bot commentedMar 21, 2022

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

dolgachio removed partially reviewed in progressTranslation in progress labels

Mar 21, 2022

AntonBurchakand others added10 commits

March 22, 2022 21:38

Apply suggestions from code review

8c95048

Co-authored-by: Stanislav <s.dolgachov@gmail.com>

Update soccer.js

98e602d

Update index.html

b966c14

Update task.md

acaea59

Update index.html

e0403bd

Update index.html

016297c

Update index.html

ea5b2b1

Apply suggestions from code review

016b25d

Co-authored-by: Stanislav <s.dolgachov@gmail.com>

Update article.md

f747b5f

Update article.md

b90a49a

AntonBurchak requested a review fromdolgachio

March 22, 2022 20:30

Copy link

ContributorAuthor

AntonBurchak commentedMar 22, 2022

@stas-dolgachov Дякую за ретельне ревью. Я вніс корективи до перекладу, будь-ласка перевірте

Copy link

ContributorAuthor

AntonBurchak commentedMar 25, 2022

/done

javascript-translate-bot added review needed and removed changes requested labels

Mar 25, 2022

dolgachio approved these changes

Mar 26, 2022

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Mar 26, 2022

Copy link

Collaborator

dolgachio commentedMar 26, 2022

Дякую за чудовий переклад!

dolgachio merged commit8a8d92e intojavascript-tutorial:master

Mar 26, 2022

Copy link

Contributor

javascript-translate-bot commentedMar 26, 2022

Thank you 💖 I updated the Progress Issue#1 🎉 🎉 🎉

Labels

needs +1

Movatterモバイル変換

Drag'n'Drop with mouse events#322

Drag'n'Drop with mouse events#322

Uh oh!

Conversation

AntonBurchak commentedFeb 23, 2022

Uh oh!

CLAassistant commentedFeb 23, 2022

Uh oh!

AntonBurchak commentedFeb 23, 2022

Uh oh!

dolgachio commentedMar 13, 2022

Uh oh!

dolgachio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dolgachioMar 21, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedMar 21, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedMar 21, 2022

Uh oh!

AntonBurchak commentedMar 22, 2022

Uh oh!

AntonBurchak commentedMar 25, 2022

Uh oh!

dolgachio commentedMar 26, 2022

Uh oh!

javascript-translate-bot commentedMar 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants