Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Loops: while and for#77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
alvar-o wants to merge13 commits intojavascript-tutorial:master
base:master
Choose a base branch
Loading
fromalvar-o:master

Conversation

alvar-o
Copy link

I'm sorry for the mess in the commits. I got my credentials right and here's the work on the chapter "Loops: while and for".

@javascript-translate-bot

Error: the article already has PR number in the Progress Issue#1, it's 50⁉️

@CLAassistant
Copy link

CLAassistant commentedOct 21, 2019
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign ourContributor License Agreement before we can accept your contribution.
2 out of3 committers have signed the CLA.

✅ alvar-o
✅ odsantos
❌ Álvaro Antonio


Álvaro Antonio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let usrecheck it.

@odsantos
Copy link
Contributor

@alvar-o Hi, I'll have to take a look at the bot messages first. Thanks.

@alvar-o
Copy link
Author

@alvar-o Hi, I'll have to take a look at the bot messages first. Thanks.

I had an issue with the credentials configured in my git, I thought I had solved it but my previous commits still show with the wrong credentials. The only way to work this out seems to be to delete my fork and start a new one, then make a new pull request. Let me know if this is needed! :)

@odsantos
Copy link
Contributor

Hi@alvar-o, if you can delete the fork, make a new one and a new PR with only one file I would appreciate.

You might be considering to clone your fork to your computer.

If you already have a cloned fork in your computer, please delete that folder before cloning your new fork. But, before deleting anything make a backup copy of your translation (save it on a file) for an easy copy/paste later.

On the PR, do not also forget to accept the license.

Thanks.

@odsantos
Copy link
Contributor

Hi@alvar-o is this still in progress?
If so, could you remove the conflicts, otherwise would you please inform of your unavailability?
Thank you.

Copy link

@herbertpdlherbertpdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just some points.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@odsantos
Copy link
Contributor

Hello@herbertpdl , only maintainers should review the pull requests on this repository.
It even has conflicts, so it is expected to be outdated.

herbertpdl reacted with thumbs up emoji

@odsantos
Copy link
Contributor

Hello@herbertpdl ,

It seems you no longer are working on this.

I am afraid I am releasing this lesson for another person within a week.

Thanks,
Osvaldo.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@herbertpdlherbertpdlherbertpdl requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alvar-o@javascript-translate-bot@CLAassistant@odsantos@herbertpdl

[8]ページ先頭

©2009-2025 Movatter.jp