Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

BigInt#430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Merged

Conversation

danilolmc
Copy link
Contributor

No description provided.

Copy link
Member

@nazarepiedadynazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@danilolmc, what do you think about consider the idea about translating the wordbigint in the article content asnúmero inteiro grande orinteiro grande orinteiro maior?

@peruibeloko,@jonnathan-ls,@odsantos, what do you think about the suggestion I did?

@peruibeloko
Copy link
Contributor

@nazarepiedady I'd keep it as BigInt, and the only change I'd suggest is to capitalize it, since we're dealing with the actual object's name, much like we shouldn't translatePromise toPromessa for example :)

nazarepiedady and jonnathan-ls reacted with heart emoji

@danilolmc
Copy link
ContributorAuthor

danilolmc commentedFeb 6, 2024
edited
Loading

I agree with@peruibeloko, since BigInt is just like Promise and the data type name itself.

@peruibeloko do you mean capitalize every bigint word in the article? I just let some bigint words as it was already capitalized.

nazarepiedady and jonnathan-ls reacted with heart emoji

@peruibeloko
Copy link
Contributor

@danilolmc Yes, that would be the case. Just a suggestion, of course.

nazarepiedady reacted with heart emoji

@danilolmc
Copy link
ContributorAuthor

Ok, no problem, I'm going to capitalize them!

nazarepiedady reacted with heart emoji

@nazarepiedady
Copy link
Member

@nazarepiedady I'd keep it as BigInt, and the only change I'd suggest is to capitalize it, since we're dealing with the actual object's name, much like we shouldn't translatePromise toPromessa for example :)

@peruibeloko, I was talking about to translate the usage of the wordbigint where it is not reference the data type.

@peruibeloko
Copy link
Contributor

@nazarepiedady the problem is thatbigint always refers to the data type

Copy link
Contributor

@peruibelokoperuibeloko left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@danilolmc Solicitei algumas mudanças, deve ser rápido

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@danilolmc
Copy link
ContributorAuthor

/done

@odsantos
Copy link
Contributor

I agree with@peruibeloko, since BigInt is just like Promise and the data type name itself.

@peruibeloko do you mean capitalize every bigint word in the article? I just let some bigint words as it was already capitalized.

Seems good, as the Portuguese 'mdn' link, and other accepted suggestions here.

@nazarepiedadynazarepiedady merged commit837287f intojavascript-tutorial:masterFeb 11, 2024
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue#1 🎉 🎉 🎉

jonnathan-ls reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nazarepiedadynazarepiedadynazarepiedady approved these changes

@odsantosodsantosAwaiting requested review from odsantos

@jonnathan-lsjonnathan-lsAwaiting requested review from jonnathan-ls

+1 more reviewer

@peruibelokoperuibelokoperuibeloko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danilolmc@peruibeloko@nazarepiedady@javascript-translate-bot@odsantos

[8]ページ先頭

©2009-2025 Movatter.jp