Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Quantifiers +, *, ? and {n}#429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

peruibeloko
Copy link
Contributor

No description provided.

@peruibelokoperuibeloko marked this pull request as ready for reviewFebruary 6, 2024 18:14
Copy link
Member

@nazarepiedadynazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@peruibeloko, you did a great work here, so there is not so much things to be reviewed.

I will let the rest on your hands and our colleagues.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@nazarepiedady
Copy link
Member

@jonnathan-ls, could you review it?

jonnathan-ls reacted with thumbs up emoji

@nazarepiedady
Copy link
Member

@peruibeloko, I think you could also look at your own pull request and approve it if you agree with what you did. This would help a lot when we don't have enough people online to look at it.

@peruibeloko
Copy link
ContributorAuthor

@nazarepiedady that would be a conflict of interests, wouldn't it? the idea of reviews is to catch errors

@nazarepiedady
Copy link
Member

@peruibeloko, yes, but you are also a reviewer even not being a maintainer. I also think that you have a good point.

@peruibeloko
Copy link
ContributorAuthor

/done

nazarepiedady reacted with thumbs up emoji

@nazarepiedady
Copy link
Member

@peruibeloko, excellent, now we can go forward.
@odsantos, and@jonnathan-ls, could you review it quickly as possible?

We need to merge all current opened pull request to do a good review on the issues and to organise the things to start to add new translations.

Copy link
Contributor

@jonnathan-lsjonnathan-ls left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM ❤️ I added my approval

nazarepiedady reacted with thumbs up emoji
@jonnathan-ls
Copy link
Contributor

that would be a conflict of interests, wouldn't it? the idea of reviews is to catch errors

I agree with@peruibeloko in relation to the translator ending up accepting the PR itself, although it is a documentation repository, if we consider the same premise as the code, whoever opened the PR may end up missing errors that they would not end up catching, hence the need to have reviewers for a look beyond the context (this corroborates the project's premise of having 02 reviewers, to avoid possible translation errors and ending up being taken to production when the translation is incorporated into the javascript.info website '

But I also consider@nazarepiedady's observation valid, unfortunately there are few contributors to this project and we need to release the translation. As it is a documentation repository and not a code repository, perhaps we can be a little more flexible, but if we are going to follow a path like this, I think it is worth creating a separate issue first to evaluate the opinion of other maintainers, at the same time time to ensure that we do not violate the premise adopted by the project owner (repository in English).

@nazarepiedady
Copy link
Member

@peruibeloko,@jonnathan-ls, unfortunately this project do not have so many active maintainers so if we depend on the maintainers that are not so active we can not go ahead.

@peruibeloko
Copy link
ContributorAuthor

@nazarepiedady I think your approval is the only one remaining

jonnathan-ls reacted with heart emoji

@nazarepiedadynazarepiedady merged commitb4ee5de intojavascript-tutorial:masterApr 2, 2024
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue#1 🎉 🎉 🎉

@peruibelokoperuibeloko deleted the 09/09 branchApril 3, 2024 01:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jonnathan-lsjonnathan-lsjonnathan-ls approved these changes

@nazarepiedadynazarepiedadynazarepiedady approved these changes

@odsantosodsantosAwaiting requested review from odsantos

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peruibeloko@javascript-translate-bot@nazarepiedady@jonnathan-ls

[8]ページ先頭

©2009-2025 Movatter.jp