Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Anchors: string start ^ and end $#420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jonnathan-ls merged 6 commits intojavascript-tutorial:masterfromperuibeloko:09/04
Jan 29, 2024

Conversation

peruibeloko
Copy link
Contributor

Usarei os termos "casar", "casamento" e "correspondência" como tradução para "match" dependendo do contexto, mas quero evitar usar outros termos para evitar confusões.

No artigo como um todo, mas específicamente no trecho

In other words, they do not match a character, but rather force the regexp engine to check the condition (text start/end).

Faltou com uma explicação simples do que as âncoras realmente representam: uma posição, que foi o que adicionei na minha tradução:

Em outras palavras, elas não casam com um carácter, mas sim com uma posição, obrigando o interpretador regex a verificar a condição de início ou fim da string.

Copy link
Member

@nazarepiedadynazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I review your changes, they are good in general, but there are some changes I would like you to look.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@peruibeloko
Copy link
ContributorAuthor

These seem pretty reasonable, I'll get to it later today. Thanks for the review Nazaré!

@peruibeloko
Copy link
ContributorAuthor

/done

Copy link
Member

@nazarepiedadynazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It seems acceptable to me, so let's see what others maintainers have to say.

@peruibeloko
Copy link
ContributorAuthor

peruibeloko commentedJan 28, 2024
edited
Loading

@jonnathan-ls Looks good to me! Thanks for fishing up the remaining bits

jonnathan-ls and nazarepiedady reacted with heart emojijonnathan-ls reacted with rocket emoji

Copy link
Contributor

@jonnathan-lsjonnathan-ls left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@peruibeloko

Tomei a liberdade de traduzir o restante de trechos em ingles, conforme commit (56d7f23), tudo bem pra ti a alteração?

Com isso, está LGTM (Looks Good To Me) ...

@jonnathan-lsjonnathan-ls merged commit1067461 intojavascript-tutorial:masterJan 29, 2024
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue#1 🎉 🎉 🎉

jonnathan-ls reacted with hooray emoji

@peruibeloko
Copy link
ContributorAuthor

@jonnathan-ls Tranquilo! Vou passar a traduzir esses trechos daqui em diante também. Obrigado pela força 🙏

jonnathan-ls and nazarepiedady reacted with heart emoji

@peruibelokoperuibeloko deleted the 09/04 branchFebruary 2, 2024 23:18
Copy link
Member

@nazarepiedadynazarepiedady left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@peruibeloko, well done, we are moving forward finally. We have some more few pull requests to review.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nazarepiedadynazarepiedadynazarepiedady approved these changes

@jonnathan-lsjonnathan-lsjonnathan-ls approved these changes

@odsantosodsantosAwaiting requested review from odsantos

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peruibeloko@javascript-translate-bot@nazarepiedady@jonnathan-ls

[8]ページ先頭

©2009-2025 Movatter.jp