javascript-tutorial/pt.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork111
Star252

Extending built-in classes#413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jonnathan-ls merged 3 commits intojavascript-tutorial:masterfromdanilolmc:builtin-classes

Jan 13, 2024

Merged

Extending built-in classes#413

jonnathan-ls merged 3 commits intojavascript-tutorial:masterfromdanilolmc:builtin-classes

Jan 13, 2024

Conversation

Copy link

Contributor

danilolmc commentedJan 4, 2024

No description provided.

danilolmc added2 commits

January 2, 2024 20:31

it updates built-in classes article

080dc0e

fix: it fixes spelling mistakes

e493488

javascript-translate-bot added the review needed label

Jan 4, 2024

javascript-translate-bot requested a review froma team

January 4, 2024 15:24

Copy link

javascript-translate-bot commentedJan 4, 2024

Error: the article already has PR number in the Progress Issue#1, it's 411⁉️

nazarepiedady reviewed

Jan 7, 2024

View reviewed changes

Copy link

Member

nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I just found two points to be reviewed, so I will pass to you@jonnathan-ls the responsibility of reviewing the rest.

1-js/09-classes/05-extend-natives/article.md OutdatedShow resolvedHide resolved

fix: it fixes grammar

f06d644

danilolmc mentioned this pull request

Jan 8, 2024

Status review for unfinished articles#416

Closed

Copy link

ContributorAuthor

danilolmc commentedJan 9, 2024

/done

javascript-translate-bot requested a review froma team

January 9, 2024 14:42

jonnathan-ls approved these changes

Jan 13, 2024

View reviewed changes

Copy link

Contributor

jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks Good To Me (LGTM)

javascript-translate-bot added needs +1 and removed review needed labels

Jan 13, 2024

Copy link

Contributor

jonnathan-ls commentedJan 13, 2024•
edited
Loading

I just found two points to be reviewed, so I will pass to you@jonnathan-ls the responsibility of reviewing the rest.

Adicionei minha aprovação!

Por mais que ainda tenha solicitado alterações@nazarepiedady, acabou marcando a opção de review como comentário ... mas considerando que o@danilolmc já adicionou as alterações, entendo que a solicitação foi atendida, configurando como aprovada, então seguirei com o merge deste PR.

Quando adicionar uma revisão que tenha solicitações de mudança@nazarepiedady, procure marcar a opção:

Request changes
Submit feedback that must be addressed before merging.

Assim, o github registra as considerações e o BOT configurado do repositório consegue atuar, acho que foi por isso que ele acabou não atualizando o status deste PR, já que registrou como comentário em vez de request changes.