javascript-tutorial/pt.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork111
Star252

Object references and copying#408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nazarepiedady merged 3 commits intojavascript-tutorial:masterfromdanilolmc:update-pt-object-copy

Dec 20, 2023

Merged

Object references and copying#408

nazarepiedady merged 3 commits intojavascript-tutorial:masterfromdanilolmc:update-pt-object-copy

Dec 20, 2023

Conversation

Copy link

Contributor

danilolmc commentedNov 29, 2023

No description provided.

danilolmc added2 commits

November 24, 2023 04:39

updates 'object and reference and copy' article

7e36a50

it fixes grammar errors

8f043f0

javascript-translate-bot added the review needed label

Nov 29, 2023

javascript-translate-bot requested a review froma team

November 29, 2023 15:57

danilolmc closed this

Nov 30, 2023

danilolmc reopened this

Nov 30, 2023

jonnathan-ls requested changes

Dec 10, 2023

View reviewed changes

Copy link

Contributor

jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Olá@danilolmc,

Eu tentei empurrar para suabranch algumas alterações simples de gramática que acabei fazendo enquanto realizava a revisão deste PR.

Porém, seu fork/user deve estar protegido para receber commits de outros usuários, acabei recebendo error depermission denied:

! [remote rejected] pr/408 -> update-pt-object-copy (permission denied)
error: failed to push some refs to 'https://github.com/danilolmc/pt.javascript.info.git'

Nesse sentido, registro abaixo as alterações que eu ia adicionar ao seu PR, poderia verificar as solicitações a seguir?

1-js/04-object-basics/02-object-copy/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot removed the review needed label

Dec 10, 2023

Copy link

javascript-translate-bot commentedDec 10, 2023

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label

Dec 10, 2023

it fixes grammar mistakes

8ae0cf1

danilolmc requested a review fromjonnathan-ls

December 17, 2023 03:34

Copy link

ContributorAuthor

danilolmc commentedDec 20, 2023

/done

javascript-translate-bot added review needed and removed changes requested labels

Dec 20, 2023

javascript-translate-bot requested a review froma team

December 20, 2023 02:40

nazarepiedady merged commit769acd2 intojavascript-tutorial:master

Dec 20, 2023

danilolmc deleted the update-pt-object-copy branch

December 21, 2023 16:50

danilolmc changed the title~~Updates Object references and copying article~~Object references and copying

Dec 22, 2023

Copy link

Contributor

jonnathan-ls commentedDec 23, 2023•
edited
Loading

@nazarepiedady como fez o merge, entendo que adicionou sua revisão como aprovada como a segunda revisora, creio ser válido deixar registrado que o PR esta aprovado, conforme seção abaixo

Após o merge não consigo realizar a atualização, mas deixo a observação para próximos PRs

A aprovação de dois revisores corrobora com a orientação deixa pelo Ilkan#1

jonnathan-ls removed the review needed label

Dec 23, 2023

Copy link

Member

nazarepiedady commentedDec 23, 2023

@jonnathan-ls, entendo, considerarei este ponto da próxima vez que precisar combinar as modificações enviadas ao repositório principal. Na primeira leitura que tinha feito pareceu-me bem o trabalho feito, por esta razão fiz a combinação, não volta acontecer.