Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

F.prototype#231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jonnathan-ls merged 11 commits intojavascript-tutorial:masterfromflaviohblima:develop-function-prototype
Sep 18, 2023
Merged

F.prototype#231

jonnathan-ls merged 11 commits intojavascript-tutorial:masterfromflaviohblima:develop-function-prototype
Sep 18, 2023

Conversation

flaviohblima
Copy link
Contributor

No description provided.

Copy link
Contributor

@odsantosodsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hello@flaviohblima ,

Here is a review.

Two files in the "1-js/08-prototypes/02-function-prototype/4-new-object-same-constructor" folder seem not yet translated.

Please, feel free to comment where you might disagree.

Thank you,
Osvaldo.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@flaviohblima
Copy link
ContributorAuthor

/done

@flaviohblima
Copy link
ContributorAuthor

Hello@odsantos ,

I missed some of your reviews in my last reading. Sorry.

Now I think I resolved everything.

I did not resolvethis one, because I do not use the "de" like this.

If its ok for you, I believe now its done.

Thank you for your reviews!
Flávio

@odsantos
Copy link
Contributor

Hello@flaviohblima ,
Thank you for your message.

I hope to check it as soon as possible. Probably, within a few days.

However, I still see my review notes. I believe I shouldn't if they were resolved and committed.
But it might be all right, as well.

Osvaldo.

Copy link
Contributor

@odsantosodsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hello@flaviohblima ,

Here is another review.

Thank you,
Osvaldo.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

flaviohblimaand others added5 commitsNovember 1, 2021 13:40
…structor/solution.mdCo-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…structor/solution.mdCo-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…structor/solution.mdCo-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
…structor/solution.mdCo-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@flaviohblima
Copy link
ContributorAuthor

/done

Copy link
Contributor

@odsantosodsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hello@flaviohblima ,

I reopened a conversation and I still am insisting on that one with 'de'.
Would you mind if I ask you to review it again?
Please, I continue open to your appreciation of my review.

Thank you,
Osvaldo.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>
@flaviohblima
Copy link
ContributorAuthor

Hello@odsantos ,

If you insist, I see no problem fixing it. I already commited the change.

Thank you,
Flávio

@flaviohblima
Copy link
ContributorAuthor

/done

Copy link
Contributor

@odsantosodsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hello@flaviohblima ,

I appreciate the patience you had.
By the rules, we need a second reviewer for your work to be merged.

Let's hope that either@luizclr,@Mr-Saxobeat,@adriavieira314, or @kiniggit have time for that.

Best regards,
Osvaldo.

@CLAassistant
Copy link

CLAassistant commentedApr 29, 2022•
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jonnathan-lsjonnathan-ls left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@flaviohblima

I recorded some notes

Note: the images (SVG) have not been translated.

I didn't add the above note in the review, but I was wondering if you could perform the script translation procedure? As per image translation guidance athttps://github.com/javascript-tutorial/server#translating-images

If not,no problem, I perform the procedure separately in another Pull Request.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@jonnathan-ls
Copy link
Contributor

/done

@jonnathan-ls
Copy link
Contributor

jonnathan-ls commentedSep 18, 2023•
edited
Loading

jonnathan-ls requested changes on behalf ofhttps://github.com/orgs/javascript-tutorial/teams/translate-pton Jul 6, 2022

I applied the corrections I requested by contributing to the PR to be able to accept the request

@jonnathan-lsjonnathan-ls merged commitb569358 intojavascript-tutorial:masterSep 18, 2023
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue#1 🎉 🎉 🎉

jonnathan-ls reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@odsantosodsantosodsantos approved these changes

@jonnathan-lsjonnathan-lsjonnathan-ls approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@flaviohblima@javascript-translate-bot@odsantos@CLAassistant@jonnathan-ls
[8]ページ先頭
©2009-2025 Movatter.jp