Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Scripts: async, defer#229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nazarepiedady merged 11 commits intojavascript-tutorial:masterfromlarissaiurk:master
Mar 17, 2024

Conversation

larissaiurk
Copy link
Contributor

No description provided.

channelbeta reacted with hooray emojiflavioheleno reacted with heart emoji
@CLAassistant
Copy link

CLAassistant commentedOct 23, 2021•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@odsantos
Copy link
Contributor

Hi@larissaiurk,

Still available for this task?
There is a conflict here.

Please, let me know if you have not time, and I might be able to resolve it.

Thanks,
Osvaldo.

@nazarepiedady
Copy link
Member

@peruibeloko,@jonnathan-ls, do you have time to see what is possible to do in relation to this pull request?

1.Scripts can't see DOM elements below them, so they can't add handlers etc.
2.If there's a bulkyscriptat the top of the page, it "blocks the page".Users can't see the page content till it downloads and runs:
1.Os scripts não conseguem ver os elementos da DOM abaixo deles, então não conseguem manipular eventos, etc.
2.Se houver umscriptvolumoso no topo da página, ele vai "bloqueia a página".Os usuários não podem ver o conteúdo da página até que ele faça o download e execute:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
2. Se houver um script volumoso no topo da página, ele vai "bloqueia a página". Os usuários não podem ver o conteúdo da página até que ele faça o download e execute:
2. Se houver um script volumoso no topo da página, ele vai "bloquear a página". Os usuários não podem ver o conteúdo da página até que ele faça o download e execute:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ajustado

@nazarepiedady
Copy link
Member

nazarepiedady commentedMar 6, 2024•
edited
Loading

@peruibeloko, could you help to fix the conflicts, update, and approve it?

peruibeloko reacted with thumbs up emoji

Copy link
Contributor

@jonnathan-lsjonnathan-ls left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

I added simple adjustments (0dfdf25) and resolved the merge conflict (b0b6ae0)

@jonnathan-ls
Copy link
Contributor

jonnathan-ls commentedMar 17, 2024•
edited
Loading

... could you help to fix the conflicts, update, and approve it?

During the review, I added simple adjustments (including the suggestion requested by@peruibeloko) and also conflict resolution@nazarepiedady

/done

Copy link
Member

@nazarepiedadynazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is good, but there are some little changes needed.

Assim como`defer`, o atributo`async` é ignorado se a tag`<script>` não tiver`src`.
```
## Dynamic scripts

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It was not translated yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done

## Dynamic scripts
There's one more important way of adding a script to the page.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It also was not translated yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@nazarepiedady
Copy link
Member

@jonnathan-ls, there are some changes that need to be translated.

jonnathan-ls reacted with thumbs up emoji

@jonnathan-ls
Copy link
Contributor

@nazarepiedady Thanks for watching, pending translation added

/done

Copy link
Member

@nazarepiedadynazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is good to be applied.

@nazarepiedadynazarepiedady merged commitdd27063 intojavascript-tutorial:masterMar 17, 2024
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue#1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jonnathan-lsjonnathan-lsjonnathan-ls approved these changes

@nazarepiedadynazarepiedadynazarepiedady approved these changes

@odsantosodsantosAwaiting requested review from odsantos

+1 more reviewer

@peruibelokoperuibelokoperuibeloko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@larissaiurk@CLAassistant@odsantos@nazarepiedady@jonnathan-ls@javascript-translate-bot@peruibeloko
[8]ページ先頭
©2009-2025 Movatter.jp