javascript-tutorial/pt.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork113
Star253

nullish-coalescing-operator finished#195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jonnathan-ls merged 22 commits intojavascript-tutorial:masterfromermogenes:master

Oct 18, 2022

Merged

nullish-coalescing-operator finished#195

jonnathan-ls merged 22 commits intojavascript-tutorial:masterfromermogenes:master

Oct 18, 2022

Conversation

Copy link

Contributor

ermogenes commentedNov 18, 2020

No description provided.

ermogenesand others added12 commits

September 25, 2020 09:39

Primeiros parágrafos

1e8e103

Conclui tradução

85fa0ee

Ajustes após comparação

8bcb495

Ajustes após comparação

b89e2cb

Ajustes após comparação

eec6a2a

Equipara termos com MDN

61f78fb

Ajustes finais

37f1dbd

Ajustes finais

54546cf

Ajustes finais

1b4c6df

Ajustes finais

efdf7bf

Ajustes finais

190fee3

Ajustes finais

bdb5d94

javascript-translate-bot added the review needed label

Nov 18, 2020

javascript-translate-bot requested a review froma team

November 18, 2020 13:50

Copy link

CLAassistant commentedNov 18, 2020•
edited
Loading

All committers have signed the CLA.

ermogenes changed the title~~Tradução de nullish-coalescing-operator finalizada~~nullish-coalescing-operator finished

Nov 18, 2020

Copy link

Contributor

odsantos commentedDec 20, 2020

Hi@ermogenes would you please resolve the conflicts, or inform if you're unavailable for this PR. Thank you.

ermogenes added3 commits

December 21, 2020 14:21

Traduz últimas alterações

b7880e6

Aceita demais alterações

5e198f7

Mergehttps://github.com/javascript-tutorial/pt.javascript.infointo …

9c92c4d

…master

Copy link

ContributorAuthor

ermogenes commentedDec 21, 2020

@odsantos conflicts resolved.

odsantos requested changes

Dec 23, 2020

View reviewed changes

Copy link

Contributor

odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@ermogenes here is a files' check.
Please feel free to also comment if somewhere you disagree.
Thank you,
Osvaldo.

1-js/02-first-steps/12-nullish-coalescing-operator/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

Dec 23, 2020

Copy link

javascript-translate-bot commentedDec 23, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

ermogenesand others added3 commits

December 28, 2020 08:00

Update 1-js/02-first-steps/12-nullish-coalescing-operator/article.md

92fa95e

Ajusta ortografiaCo-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>

Update 1-js/02-first-steps/12-nullish-coalescing-operator/article.md

f756172

Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>

Update 1-js/02-first-steps/12-nullish-coalescing-operator/article.md

025b51b

Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>

Copy link

ContributorAuthor

ermogenes commentedDec 28, 2020

/done

javascript-translate-bot removed the changes requested label

Dec 28, 2020

javascript-translate-bot added the review needed label

Dec 28, 2020

javascript-translate-bot requested a review froma team

December 28, 2020 11:07

Remove blank lines.

1ec73c8

odsantos approved these changes

Dec 29, 2020

View reviewed changes

Copy link

Contributor

odsantos left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@ermogenes , the translation lines for the English line 44 and ahead seem not to match. Is it possible to delete the Portuguese extra blank lines (between line 43 and 47) to remove the discrepancy? Thank you.

javascript-translate-bot added needs +1 and removed review needed labels

Dec 29, 2020

Copy link

ContributorAuthor

ermogenes commentedDec 29, 2020

@odsantos Despite what GH shows in compare, I couldn't manage to locate the discrepancy. To me both files has the same line numbers and no extra breaks or spaces.

Copy link

Contributor

odsantos commentedDec 29, 2020

@ermogenes Thank you.

Copy link

Contributor

odsantos commentedMay 20, 2021

Hi@ermogenes,

This PR has one approval.
I wonder if it would be possible to keep it with no conflicts until another reviewer might approve it as well.
If you are not available to do it, would you please let me know to see if I might be able to do that?

Thank you,
Osvaldo.