javascript-tutorial/pt.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork113
Star253

Iterables#118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

marcoarib wants to merge28 commits intojavascript-tutorial:masterfrommarcoarib:master

Closed

Iterables#118

marcoarib wants to merge28 commits intojavascript-tutorial:masterfrommarcoarib:master

Conversation

Copy link

marcoarib commentedApr 27, 2020

No description provided.

marcoarib added21 commits

April 23, 2020 07:48

Update article.md

dade2bd

Update article.md

6d67d5b

Update article.md

88ce293

Update article.md

b843ca3

Update article.md

f895fe4

Update article.md

517d8c3

Update article.md

78213c8

Update article.md

9ef8682

Update article.md

5192c9b

Update article.md

715cb27

Update article.md

7adea35

Update article.md

914d0f3

Update article.md

b77d133

Update article.md

22d766d

Update article.md

e0741c9

Update article.md

4492877

Update article.md

d09624f

Update article.md

d8b77a1

Update article.md

b856cfb

Update article.md

3aab577

Update article.md

251c3d1

javascript-translate-bot added the review needed label

Apr 27, 2020

javascript-translate-bot requested a review froma team

April 27, 2020 01:26

Copy link

CLAassistant commentedApr 27, 2020•
edited
Loading

All committers have signed the CLA.

iliakan mentioned this pull request

Apr 27, 2020

Portuguese Translation Progress#1

Open

marcoarib added4 commits

April 27, 2020 08:36

Update article.md

565b3ea

Update article.md

dc3d009

Update article.md

7fa985c

Update article.md

d1c58b9

Copy link

Contributor

wnleao commentedMay 9, 2020

Hey, Marco! Could you join all commits in only 1?

Copy link

Contributor

wnleao commentedMay 9, 2020

Btw, did you check if the english version had changes? Some pt-br articles are way back...https://github.com/javascript-tutorial/en.javascript.info

marcoarib added3 commits

May 9, 2020 19:24

Update article.md

cbcbae6

Update article.md

8f763f1

Update article.md

78c281c

Copy link

Author

marcoarib commentedMay 9, 2020

Hey, Marco! Could you join all commits in only 1?

How can I do that? I'm not familiarized with Github editing.
Thanks.

Copy link

Contributor

wnleao commentedMay 9, 2020

Hey, Marco! Could you join all commits in only 1?
How can I do that? I'm not familiarized with Github editing.
Thanks.

No problem. Are you using the command line? Check out this link:https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

Copy link

Contributor

wnleao commentedMay 9, 2020

Also, I've seen in your translation that you're translating code aswell. We should keep the source code as in the original and only translate comments.

Copy link

Contributor

wnleao commentedMay 9, 2020•
edited
Loading

Later on, whenever you want to change your last commit, like picking up from where you left off, you should usegit commit --amend check out more details inhttps://www.atlassian.com/br/git/tutorials/rewriting-history

Copy link

Author

marcoarib commentedMay 10, 2020

Hey, Marco! Could you join all commits in only 1?
How can I do that? I'm not familiarized with Github editing.
Thanks.
No problem. Are you using the command line? Check out this link:https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

I'm using browser.

Copy link

Contributor

wnleao commentedMay 10, 2020

Hey, marco! Could you finish up reviewing#121 ? I've already done a thorough review and Ana already changed what had to be changed. We need 2 people to review n order to approve the PR. Cheers!

Copy link

Contributor

wnleao commentedMay 11, 2020

Hey, Marco! Could you join all commits in only 1?
How can I do that? I'm not familiarized with Github editing.
Thanks.
No problem. Are you using the command line? Check out this link:https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git
I'm using browser.

I don't know how to squash commits using github site, but let me know when you're done and I'll try to squash your commits over here. Ok?

Copy link

Contributor

odsantos commentedDec 6, 2020

Hi@marcoarib please could you also resolve the conflicts? Thank you.

Copy link

Contributor

odsantos commentedJan 28, 2023

Hi@marcoarib , "Object.keys, values, entries" is not part of "Iterables".
Would you remove it from this Pull Request and create a separate one for it?
Would you also resolve the conflicts?
Thanks.

Copy link

Member

nazarepiedady commentedMar 10, 2024

@peruibeloko,@jonnathan-ls,@odsantos, we need some solution to this pull request. I am thinking on to close it and start a new one with updates applied and conflicts resolved.