Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Iterables#118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
marcoarib wants to merge28 commits intojavascript-tutorial:masterfrommarcoarib:master
Closed

Iterables#118

marcoarib wants to merge28 commits intojavascript-tutorial:masterfrommarcoarib:master

Conversation

marcoarib
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commentedApr 27, 2020
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wnleao
Copy link
Contributor

Hey, Marco! Could you join all commits in only 1?

@wnleao
Copy link
Contributor

Btw, did you check if the english version had changes? Some pt-br articles are way back...https://github.com/javascript-tutorial/en.javascript.info

@marcoarib
Copy link
Author

Hey, Marco! Could you join all commits in only 1?

How can I do that? I'm not familiarized with Github editing.
Thanks.

@wnleao
Copy link
Contributor

Hey, Marco! Could you join all commits in only 1?

How can I do that? I'm not familiarized with Github editing.
Thanks.

No problem. Are you using the command line? Check out this link:https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

@wnleao
Copy link
Contributor

Also, I've seen in your translation that you're translating code aswell. We should keep the source code as in the original and only translate comments.

@wnleao
Copy link
Contributor

wnleao commentedMay 9, 2020
edited
Loading

Later on, whenever you want to change your last commit, like picking up from where you left off, you should usegit commit --amend check out more details inhttps://www.atlassian.com/br/git/tutorials/rewriting-history

@marcoarib
Copy link
Author

Hey, Marco! Could you join all commits in only 1?

How can I do that? I'm not familiarized with Github editing.
Thanks.

No problem. Are you using the command line? Check out this link:https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

I'm using browser.

@wnleao
Copy link
Contributor

Hey, marco! Could you finish up reviewing#121 ? I've already done a thorough review and Ana already changed what had to be changed. We need 2 people to review n order to approve the PR. Cheers!

@wnleao
Copy link
Contributor

Hey, Marco! Could you join all commits in only 1?

How can I do that? I'm not familiarized with Github editing.
Thanks.

No problem. Are you using the command line? Check out this link:https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

I'm using browser.

I don't know how to squash commits using github site, but let me know when you're done and I'll try to squash your commits over here. Ok?

@odsantos
Copy link
Contributor

Hi@marcoarib please could you also resolve the conflicts? Thank you.

@odsantos
Copy link
Contributor

Hi@marcoarib , "Object.keys, values, entries" is not part of "Iterables".
Would you remove it from this Pull Request and create a separate one for it?
Would you also resolve the conflicts?
Thanks.

@nazarepiedady
Copy link
Member

@peruibeloko,@jonnathan-ls,@odsantos, we need some solution to this pull request. I am thinking on to close it and start a new one with updates applied and conflicts resolved.

@peruibeloko
Copy link
Contributor

@nazarepiedady I'll fork and update it

nazarepiedady reacted with thumbs up emoji

@marcoaribmarcoarib closed this by deleting the head repositoryNov 7, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marcoarib@CLAassistant@wnleao@odsantos@nazarepiedady@peruibeloko@javascript-translate-bot

[8]ページ先頭

©2009-2025 Movatter.jp