- Notifications
You must be signed in to change notification settings - Fork850
[async/await] article 번역#345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
제가 메일로 공유드렸는데, 본 PR은 모든 request에서 503에러가 뜨네요... |
Member
Violet-Bora-Lee commentedOct 29, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Violet-Bora-Lee added a commit that referenced this pull requestOct 29, 2019
- co-author:@sojeongw- promise.all관련 부분 추가 보완 필요함-javascript-tutorial/en.javascript.info#1548 이슈 반영해야 함
ContributorAuthor
sojeongw commentedOct 30, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
보완하신 내용 잘 보았습니다! 번역이 안된 부분은 제가 이어서 하는 건가요, 아니면 보라님이 나중에 해결하려고 남겨놓으신 건가요? 하실 예정이면 PR 닫으려구요! |
넵 제가 promise부분 마무리 하면서 같이 마무리하려구요. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Pull Request 체크리스트
TODO
'함수 XX' 규칙이 이번 글에도 해당되는지 모르겠네요. 번역하면서 조금 어색하다고 느꼈거든요.
특히 133, 254번 라인이 그랬습니다.
171번 라인 번역이 좀 헷갈리네요. 확인 부탁드리겠습니다.