javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star601

Type Conversions#57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

lizzie136 merged 8 commits intojavascript-tutorial:masterfromtikoflano:master

Aug 22, 2019

Merged

Type Conversions#57

lizzie136 merged 8 commits intojavascript-tutorial:masterfromtikoflano:master

Aug 22, 2019

Conversation

Copy link

Contributor

tikoflano commentedJun 6, 2019

No description provided.

tikoflano added2 commits

May 28, 2019 01:42

Update article.md

f976410

Primera edicion

Corrección de errores menores

773a22a

javascript-translate-bot added the review needed label

Jun 6, 2019

javascript-translate-bot requested a review froma team

June 6, 2019 01:51

Copy link

CLAassistant commentedJun 6, 2019•
edited
Loading

All committers have signed the CLA.

lizzie136 reviewed

Jun 6, 2019

View reviewed changes

1-js/02-first-steps/06-type-conversions/article.md Outdated


		There are also cases when we need to explicitly convert a value to the expected type.
		Tmabién hay casos donde necesitamos convertir de manera explícita un valor al tipo esperado.

Copy link

Member

lizzie136Jun 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

También

Copy link

ContributorAuthor

tikoflanoJun 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It seems you reviewed the wrong commit. That was fixed in the latest one.

I will update this PR with the translation of task and solution.

Copy link

Member

lizzie136Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@tikoflano It keeps showing "Tmabién" and other comments. Can you confirm that you updated the parts I commented you about?

tikoflano added2 commits

June 8, 2019 21:47

Task translation

9ff5db7

Solutions translation

9ec05fa

lizzie136 self-requested a review

June 26, 2019 19:32

lizzie136 reviewed

Jul 1, 2019

View reviewed changes

1-js/02-first-steps/06-type-conversions/article.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/06-type-conversions/article.md Outdated


		There are also cases when we need to explicitly convert a value to the expected type.
		Tmabién hay casos donde necesitamos convertir de manera explícita un valor al tipo esperado.

Copy link

Member

lizzie136Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@tikoflano It keeps showing "Tmabién" and other comments. Can you confirm that you updated the parts I commented you about?

Typo fixes

8a6090c

Copy link

ContributorAuthor

tikoflano commentedJul 2, 2019

I fixed the typos. I'm curious about the "Tmabién" at line 7. I double checked that is ok in the "Files changed" of this PR.

tscandalitta reviewed

Jul 14, 2019

View reviewed changes

1-js/02-first-steps/06-type-conversions/article.md OutdatedShow resolvedHide resolved

tscandalitta reviewed

Jul 14, 2019

View reviewed changes

1-js/02-first-steps/06-type-conversions/article.md OutdatedShow resolvedHide resolved

tscandalitta reviewed

Jul 14, 2019

View reviewed changes

1-js/02-first-steps/06-type-conversions/article.md OutdatedShow resolvedHide resolved

tscandalitta reviewed

Jul 14, 2019

View reviewed changes

1-js/02-first-steps/06-type-conversions/article.md OutdatedShow resolvedHide resolved

tscandalitta reviewed

Jul 14, 2019

View reviewed changes

1-js/02-first-steps/06-type-conversions/article.md OutdatedShow resolvedHide resolved

tscandalitta reviewed

Jul 14, 2019

View reviewed changes

1-js/02-first-steps/06-type-conversions/article.md

		- `undefined`is `NaN`as a number, not `0`.
		- `"0"`and space-only strings like`" "`aretrue as a boolean.
		- `undefined`es `NaN`como número, no `0`.
		- `"0"`y textos que solo contienen espacios como`" "`son `true` como boolean.

Copy link

Collaborator

tscandalittaJul 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Quedaría mejor cadenas en lugar de textos

Copy link

ContributorAuthor

tikoflanoJul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

En todo el resto del artículo se usa la palabra "texto". Creo que "cadena" o "cadena de caracteres" puede confundir al lector ya que no se ha explicado lo que es.