- Notifications
You must be signed in to change notification settings - Fork230
Shadow DOM slots, composition#561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
joaquinelio left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hola
muy bueno
acepta las sug que quieras
cualquier cosa. se puede discutir
ah, cambie el nombre pra q Don Bot se entere.
pfffff no se enteró, edito el progress a mano#17
notas
podes editar online el PR,
tamb podes modif tu branch local y cuando lo subis con push se modifica el pr automaticamente
modificaste tu master, no es problema para mi
pero la idea es tener tu master SIEMPRE LIMPIO, sincronizado con master upstream
haces branch
ej max : branch1
lo modificas, lo subis, y con suerte te lo aceptan
1
si upstram:master se actualiza sin tu pr, el tuyo no quedaria desencajado
2
podes hacer otra modifcacion independiente en branch2 sin trrastear la primera
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
javascript-translate-bot commentedOct 13, 2021
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
MaxSierra16 commentedOct 14, 2021
@joaquinelio Gracias por tus observaciones. De verdad fueron muy acertadas. Hoy mismo estare pushiando los cambios 🚀 |
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
MaxSierra16 commentedOct 15, 2021
/done |
joaquinelio left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Lo lei y me parecio muy bien,
pero 2 sugerencias que no incorporaste y me parece que deben resolverse
447 .... "los métodos: " o "estos métodos : "
...
...
451, pienso tmbién cómo es más facil leer
evito el potencial y el reflexivo "nos gustaría"
"Si queremos saber, podemos..."
o
"Si quisiéramos saber, podríamos "
Si no contestás lo agrego como está,
preferible online aunque tuviera errores
MaxSierra16 commentedOct 18, 2021
Cool 🚀 |
MaxSierra16 commentedOct 18, 2021
/done |
joaquinelio left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
no puedo verlo bien ahora
estaba bueno antes ,estara mejor ahora, cheqealo online,
problemas, nuevo pr y cuandopueda vuelvo
salud
javascript-translate-bot commentedOct 18, 2021
Thank you 💖 I updated the Progress Issue#17 🎉 🎉 🎉 |
joaquinelio commentedOct 18, 2021
👍 |
No description provided.