Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Shadow DOM slots, composition#561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
joaquinelio merged 16 commits intojavascript-tutorial:masterfromMaxSierra16:master
Oct 18, 2021

Conversation

@MaxSierra16
Copy link
Contributor

No description provided.

Copy link
Member

@joaquineliojoaquinelio left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hola

muy bueno

acepta las sug que quieras
cualquier cosa. se puede discutir

ah, cambie el nombre pra q Don Bot se entere.
pfffff no se enteró, edito el progress a mano#17

notas
podes editar online el PR,
tamb podes modif tu branch local y cuando lo subis con push se modifica el pr automaticamente

modificaste tu master, no es problema para mi
pero la idea es tener tu master SIEMPRE LIMPIO, sincronizado con master upstream
haces branch
ej max : branch1
lo modificas, lo subis, y con suerte te lo aceptan
1
si upstram:master se actualiza sin tu pr, el tuyo no quedaria desencajado
2
podes hacer otra modifcacion independiente en branch2 sin trrastear la primera

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquineliojoaquinelio changed the titleTraduccion Shadow DOM slots, composiciónShadow DOM slots, compositionOct 13, 2021
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaxSierra16
Copy link
ContributorAuthor

@joaquinelio Gracias por tus observaciones. De verdad fueron muy acertadas. Hoy mismo estare pushiando los cambios 🚀

MaxSierra16and others added10 commitsOctober 15, 2021 10:54
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaxSierra16
Copy link
ContributorAuthor

/done

@MaxSierra16MaxSierra16 requested review fromjoaquinelio and removed request fora teamOctober 15, 2021 15:30
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Lo lei y me parecio muy bien,

pero 2 sugerencias que no incorporaste y me parece que deben resolverse

447 .... "los métodos: " o "estos métodos : "
...
...

451, pienso tmbién cómo es más facil leer
evito el potencial y el reflexivo "nos gustaría"

"Si queremos saber, podemos..."
o
"Si quisiéramos saber, podríamos "

Si no contestás lo agrego como está,
preferible online aunque tuviera errores

@MaxSierra16
Copy link
ContributorAuthor

Si queremos saber, podemos

Cool 🚀

@MaxSierra16
Copy link
ContributorAuthor

/done

@MaxSierra16MaxSierra16 requested review fromjoaquinelio and removed request fora teamOctober 18, 2021 13:00
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

no puedo verlo bien ahora
estaba bueno antes ,estara mejor ahora, cheqealo online,
problemas, nuevo pr y cuandopueda vuelvo
salud

MaxSierra16 reacted with hooray emoji
@joaquineliojoaquinelio merged commit5652645 intojavascript-tutorial:masterOct 18, 2021
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue#17 🎉 🎉 🎉

@joaquinelio
Copy link
Member

👍

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaxSierra16@javascript-translate-bot@joaquinelio

[8]ページ先頭

©2009-2025 Movatter.jp