- Notifications
You must be signed in to change notification settings - Fork230
Custom elements#495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Custom elements#495
Changes fromall commits
Commits
Show all changes
15 commits Select commitHold shift + click to select a range
c8f74ca
Custom elements
joaquineliocea42f1
Merge branch 'master' into cu
joaquineliob19f64e
Update article.md
joaquinelioae0758b
Update article.md
joaquinelio9d8d171
Update article.md
joaquinelio1870710
Update article.md
joaquinelio439023e
Update article.md
joaquinelio793d577
Update article.md
joaquinelio20e6610
Update article.md
joaquinelio852040b
Update solution.md
joaquinelioeac482a
Update solution.md
joaquineliofebdf7e
Update task.md
joaquinelio14dc134
Update article.md
joaquinelio1fda14e
Update article.md
joaquinelio919de36
Update article.md
joaquinelioFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
6 changes: 3 additions & 3 deletions8-web-components/2-custom-elements/1-live-timer/solution.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
Por favor ten en cuenta: | ||
1.Borramos el temporizador`setInterval`cuando el elemento es quitado del documento. Esto es importante, de otro modo continuará ejecutando aunque no se lo necesite más, y el navegador no puede liberar la memoria asignada a este elemento. | ||
2.Podemos acceder a la fecha actual con la propiedad`elem.date`. Todos los métodos y propiedades de clase son naturalmente métodos y propiedades del elemento. |
2 changes: 1 addition & 1 deletion8-web-components/2-custom-elements/1-live-timer/solution.view/live-timer.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions8-web-components/2-custom-elements/1-live-timer/source.view/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion8-web-components/2-custom-elements/1-live-timer/source.view/live-timer.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
class LiveTimer extends HTMLElement { | ||
/*tu código aquí */ | ||
} | ||
14 changes: 7 additions & 7 deletions8-web-components/2-custom-elements/1-live-timer/task.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.