javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star600

Forms: event and method submit#454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

joaquinelio merged 16 commits intojavascript-tutorial:masterfrompuntope:Forms-event-and-method-submit

Dec 14, 2020

Merged

Forms: event and method submit#454

joaquinelio merged 16 commits intojavascript-tutorial:masterfrompuntope:Forms-event-and-method-submit

Dec 14, 2020

Conversation

Copy link

Contributor

puntope commentedDec 9, 2020

No description provided.

puntope added5 commits

December 9, 2020 22:13

Forms: event and method submit

21fb24e

Update task.md

af25299

Update solution.md

62f6bc5

Update index.html

7a8321a

Update index.html

a1bf500

javascript-translate-bot added the review needed label

Dec 9, 2020

javascript-translate-bot requested a review froma team

December 9, 2020 21:46

Copy link

CLAassistant commentedDec 9, 2020•
edited
Loading

All committers have signed the CLA.

joaquinelio requested changes

Dec 10, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

bienvenido

algunos acentos,
las cuestiones de forma podes ignorarme, el articulo es muy claro

tuviste el criterio de traducir value pero no name o type...
aja...
es que siempre ando buscando reviewers, aunque el bot te ignore podes dejar las correcciones y comentarios

otra forma de ayudar,
cada tanto hacemos merge desde ingles,
cuando hay más de un par de lineas descarto los cambios y los paso a issues. "actualizar"
Por un lado es mas facil porque es menos cantidad,
por otro lado mas complejo porque hay que comparar con el repo ingles,
revisar el historial de commits, y corregir los nros de lineas (me ayudo con vscode +gitlens que hace diff con cualquier remoto)

2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md OutdatedShow resolvedHide resolved

2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.view/index.html OutdatedShow resolvedHide resolved

2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md OutdatedShow resolvedHide resolved

2-ui/4-forms-controls/4-forms-submit/article.md OutdatedShow resolvedHide resolved

2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md OutdatedShow resolvedHide resolved

2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md OutdatedShow resolvedHide resolved

2-ui/4-forms-controls/4-forms-submit/article.mdShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

Dec 10, 2020

Copy link

javascript-translate-bot commentedDec 10, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Copy link

Member

joaquinelio commentedDec 10, 2020

Cambio titulo, agrego al issue a mano
confirmarlo al hacer merge

joaquinelio changed the title~~Forms event and method submit~~Forms: event and method submit

Dec 10, 2020

joaquinelio mentioned this pull request

Dec 10, 2020

Spanish Translation Progress#17

Open

puntopeand others added9 commits

December 10, 2020 20:34

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md

ed8bf56

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md

a3f2a94

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.v…

d5f8910

…iew/index.htmlCo-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md

b7350f2

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md

9164cba

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/article.md

9e2559a

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md

a1e0e94

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md

8132ed7

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md

f782995

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Copy link

ContributorAuthor

puntope commentedDec 10, 2020

/done

puntope closed this

Dec 10, 2020

javascript-translate-bot added review needed and removed changes requested labels

Dec 10, 2020

javascript-translate-bot requested a review froma team

December 10, 2020 19:36

puntope reopened this

Dec 10, 2020

Copy link

ContributorAuthor

puntope commentedDec 10, 2020

/done

Copy link

Member

joaquinelio commentedDec 10, 2020•
edited
Loading

hola,@puntope
casi ok
eeehhh... quedaron dos sin resolver,
de los que no negocio, "a veces" y un typo

edit
ah, ok: pereza de github "2 hidden...show more"

puntopeand others added2 commits

December 10, 2020 22:54

Update 2-ui/4-forms-controls/4-forms-submit/article.md

91715b7

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/4-forms-controls/4-forms-submit/article.md

7cbe071

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Copy link

ContributorAuthor

puntope commentedDec 10, 2020

/done

joaquinelio approved these changes

Dec 10, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

wow that s was fast
...

yes!
👍

waiting for the second reviewer now...

javascript-translate-bot added needs +1 and removed review needed labels

Dec 10, 2020

vplentinax approved these changes

Dec 13, 2020

View reviewed changes

Copy link

Contributor

vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Todo bien...

vplentinax added ready to merge and removed needs +1 labels

Dec 13, 2020

joaquinelio merged commit85b14d2 intojavascript-tutorial:master

Dec 14, 2020

Copy link

javascript-translate-bot commentedDec 14, 2020

Thank you 💖 I updated the Progress Issue#17 🎉 🎉 🎉

puntope deleted the Forms-event-and-method-submit branch

December 14, 2020 09:43

Labels

ready to merge

5 participants

Movatterモバイル変換

Forms: event and method submit#454

Forms: event and method submit#454

Uh oh!

Conversation

puntope commentedDec 9, 2020

Uh oh!

CLAassistant commentedDec 9, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedDec 10, 2020

Uh oh!

joaquinelio commentedDec 10, 2020

Uh oh!

puntope commentedDec 10, 2020

Uh oh!

puntope commentedDec 10, 2020

Uh oh!

joaquinelio commentedDec 10, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

puntope commentedDec 10, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commentedDec 14, 2020

Uh oh!

Uh oh!

CLAassistant commentedDec 9, 2020•
edited
Loading

joaquinelio commentedDec 10, 2020•
edited
Loading