Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Element size and scrolling#433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

lgabrielvleon
Copy link
Contributor

Traducción del capítulo Element size and scrolling

@CLAassistant
Copy link

CLAassistant commentedOct 22, 2020•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@joaquineliojoaquinelio changed the titleLgabrielvleon patch 1 - Element size and scrollingElement size and scrollingOct 22, 2020
@joaquinelio
Copy link
Member

joaquinelio commentedOct 22, 2020•
edited
Loading

Corregido nombre pr / issue17 pa'que Bot lo entienda

MERGE: !!!!!!!!!!!!!!!!!!!!!!!!!!!!
Tiene 4 tasks y mucho formato anidado,
verificar online como quedan, imposible probarlo debtro del hub

Listo, cuando se me pase la pereza lo reviso.
Hasta mañana zzzz

@joaquineliojoaquinelio self-requested a reviewOctober 22, 2020 12:31
@vplentinaxvplentinax requested review fromvplentinax and removed request fora teamOctober 25, 2020 17:01
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

varias cosas...
suelo re-revisar mi revision pero me estoy durmiendo

creo que edite el archivo para cambiar numeracion, si no fue en otro

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

lgabrielvleonand others added2 commitsOctober 25, 2020 19:13
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
…task.mdCo-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Copy link
ContributorAuthor

@lgabrielvleonlgabrielvleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

/done

Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Creo que hoy tengo los ojos más limpios, encontré varios acentos faltantes...

Y vi que hay correcciones de tilde no aplicadas. Puedo dejarme convencer en css, pero con los acentos estoy bastante convencido...

Lo importante es que el texto se lee bien, lo prefiero online-

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio
Copy link
Member

@vplentinax
podes hacer lo mismo aqui?
este pr es completo, fue revisado, lo corrigio,
más revision y asi quedó

Tuvo ya mucho trabajo hecho, si te parece revisa y revisa mi revision,
es una buena adicion al repo

vplentinax reacted with thumbs up emoji

vplentinaxand others added16 commitsDecember 17, 2020 12:56
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
…tion.mdCo-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Copy link
Contributor

@vplentinaxvplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Lo veo bien. Avancemos.

@joaquineliojoaquinelio merged commitbf393d0 intojavascript-tutorial:masterDec 17, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue#17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@joaquineliojoaquineliojoaquinelio requested changes

@vplentinaxvplentinaxvplentinax approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@lgabrielvleon@CLAassistant@joaquinelio@javascript-translate-bot@vplentinax
[8]ページ先頭
©2009-2025 Movatter.jp