javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star600

Methods of RegExp and String#414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

joaquinelio merged 53 commits intojavascript-tutorial:masterfromdbritto-dev:methods-of-regexp-and-string

Oct 12, 2020

Merged

Methods of RegExp and String#414

joaquinelio merged 53 commits intojavascript-tutorial:masterfromdbritto-dev:methods-of-regexp-and-string

Oct 12, 2020

Conversation

Copy link

Contributor

dbritto-dev commentedOct 9, 2020

No description provided.

dbritto-dev added2 commits

October 8, 2020 20:45

Update article

1e65c04

Minor changes

54be322

javascript-translate-bot added the review needed label

Oct 9, 2020

javascript-translate-bot requested a review froma team

October 9, 2020 01:48

javascript-translate-bot mentioned this pull request

Oct 9, 2020

Spanish Translation Progress#17

Open

Copy link

ContributorAuthor

dbritto-dev commentedOct 9, 2020

@joaquinelio yo creo que ahora ya esta bien

joaquinelio requested changes

Oct 9, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Si rescribis en lugar de usar las suggest, cuida los acentos que les agregué/quité
una de las correccione esta sin suggest porque el md con graves me lo impide
para mi es valido "retornar" como el "devolver" que sugerimos en todos lados, no se que piensan otros. Sugerimos consistencia pero no creo que esto confunda a nadie.
no creo que debas usarr lista en lugar de array, para quien solo sepa js lista no tiene entidad. No lo puse en suggest porque en el momento dudaba...

9-regular-expressions/17-regexp-methods/article.md OutdatedShow resolvedHide resolved

9-regular-expressions/17-regexp-methods/article.mdShow resolvedHide resolved

9-regular-expressions/17-regexp-methods/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

Oct 9, 2020

Copy link

javascript-translate-bot commentedOct 9, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

dbritto-devand others added7 commits

October 9, 2020 00:40

Update 9-regular-expressions/17-regexp-methods/article.md

8ef9599

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

4d41571

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

7b2518f

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

7a16104

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

1e5511a

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

8751d21

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

16d7b40

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

dbritto-dev commented

Oct 9, 2020

View reviewed changes

9-regular-expressions/17-regexp-methods/article.md OutdatedShow resolvedHide resolved

dbritto-devand others added12 commits

October 9, 2020 08:42

Update 9-regular-expressions/17-regexp-methods/article.md

d68d2e5

Update 9-regular-expressions/17-regexp-methods/article.md

926c7e8

Update 9-regular-expressions/17-regexp-methods/article.md

67526f9

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

ca29636

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

3ba321c

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

478c5c6

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

369b9c0

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

3ecea79

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

8096bbb

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

f24cab8

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

0c276b1

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

3c5ed4a

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

dbritto-devand others added7 commits

October 9, 2020 13:54

Update 9-regular-expressions/17-regexp-methods/article.md

72cf0c6

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

9e5ef9a

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

a2e4467

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

e9c5ba7

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

f55acf7

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

bd7e456

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 9-regular-expressions/17-regexp-methods/article.md

89d3487

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

dbritto-dev commented

Oct 9, 2020

View reviewed changes

9-regular-expressions/17-regexp-methods/article.md OutdatedShow resolvedHide resolved

Update 9-regular-expressions/17-regexp-methods/article.md

bb0743e

Copy link

ContributorAuthor

dbritto-dev commentedOct 9, 2020

/done

javascript-translate-bot added review needed and removed changes requested labels

Oct 9, 2020

javascript-translate-bot requested a review froma team

October 9, 2020 19:18

joaquinelio requested changes

Oct 9, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

AAAHHHH!!!
¿¿¿Lo pase al ingles con el signo "!" ????? sorrysorrysorrysorrysorry

linea 274
supongo que w+ es solamente "world"

ya está, me quemé.
perdon si los arrastre a uds tambien...

9-regular-expressions/17-regexp-methods/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot removed the review needed label

Oct 9, 2020

Copy link

javascript-translate-bot commentedOct 9, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label

Oct 9, 2020

Update 9-regular-expressions/17-regexp-methods/article.md

cd3db66

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Copy link

ContributorAuthor

dbritto-dev commentedOct 9, 2020

/done

javascript-translate-bot added review needed and removed changes requested labels

Oct 9, 2020

javascript-translate-bot requested a review froma team

October 9, 2020 20:30

joaquinelio approved these changes

Oct 9, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Oct 9, 2020

vplentinax approved these changes

Oct 12, 2020

View reviewed changes

Copy link

Contributor

vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

vplentinax added ready to merge and removed needs +1 labels

Oct 12, 2020

joaquinelio merged commitcab278a intojavascript-tutorial:master

Oct 12, 2020

Copy link

javascript-translate-bot commentedOct 12, 2020

Thank you 💖 I updated the Progress Issue#17 🎉 🎉 🎉

Labels

ready to merge

4 participants

Movatterモバイル変換

Methods of RegExp and String#414

Methods of RegExp and String#414

Uh oh!

Conversation

dbritto-dev commentedOct 9, 2020

Uh oh!

dbritto-dev commentedOct 9, 2020

Uh oh!

joaquinelio left a comment• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedOct 9, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dbritto-dev commentedOct 9, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

javascript-translate-bot commentedOct 9, 2020

Uh oh!

dbritto-dev commentedOct 9, 2020

Uh oh!

vplentinax left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commentedOct 12, 2020

Uh oh!

Uh oh!

joaquinelio left a comment•
edited
Loading