javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star600

Date and Time#352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

joaquinelio merged 30 commits intojavascript-tutorial:masterfromFedebornaz:date-and-time

Aug 28, 2020

Merged

Date and Time#352

joaquinelio merged 30 commits intojavascript-tutorial:masterfromFedebornaz:date-and-time

Aug 28, 2020

Conversation

Copy link

Contributor

Fedebornaz commentedAug 18, 2020

Traducción del artículo Date and Time con sus respectivos ejercicios.

Traducción del artículo Date and Time

81b3a90

javascript-translate-bot added the review needed label

Aug 18, 2020

Copy link

CLAassistant commentedAug 18, 2020•
edited
Loading

All committers have signed the CLA.

Copy link

Collaborator

maksumi commentedAug 19, 2020

Revisando

joaquinelio requested changes

Aug 19, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ok, lindo trabajo

Linea 97
agregaie ``` que falta (marca el final de un box), que no puedo agregar como suggest
ademass con eso los nros de linea van a coincidir

1-js/05-data-types/11-date/1-new-date/solution.md OutdatedShow resolvedHide resolved

1-js/05-data-types/11-date/3-weekday/task.md OutdatedShow resolvedHide resolved

1-js/05-data-types/11-date/4-get-date-ago/solution.md OutdatedShow resolvedHide resolved

1-js/05-data-types/11-date/4-get-date-ago/task.md OutdatedShow resolvedHide resolved

1-js/05-data-types/11-date/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

Aug 19, 2020

Copy link

javascript-translate-bot commentedAug 19, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

iliakan mentioned this pull request

Aug 19, 2020

Spanish Translation Progress#17

Open

Fedebornazand others added19 commits

August 19, 2020 11:31

Update 1-js/05-data-types/11-date/1-new-date/solution.md

0230231

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/3-weekday/task.md

5ed3cfa

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/4-get-date-ago/solution.md

c815759

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/4-get-date-ago/task.md

3d69f63

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/4-get-date-ago/task.md

8ed2752

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/5-last-day-of-month/task.md

b5bf760

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/5-last-day-of-month/task.md

d60abda

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md

79c88fb

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md

415e063

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md

4f5de13

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/8-format-date-relative/task.md

f619ed7

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md

602a2d1

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md

4fce385

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md

6c114e2

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md

401c423

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md

80b74c7

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/11-date/article.md

6b4af91

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

agregados caracteres de cierre de box en línea 97

d53946c

Merge branch 'date-and-time' ofhttps://github.com/Fedebornaz/es.java…

ee2b149

…script.info into date-and-time

Copy link

ContributorAuthor

Fedebornaz commentedAug 19, 2020

/done

javascript-translate-bot removed the changes requested label

Aug 19, 2020

javascript-translate-bot added the review needed label

Aug 19, 2020

joaquinelio added4 commits

August 19, 2020 17:14

Update article.md

48e5264

Update task.md

b59c98c

Update solution.md

191567f

Update article.md

1f4722f

joaquinelio approved these changes

Aug 19, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Me atreví a hacer unos commits así pasamos directamente a 2da revisión,
typos, "función", "desde" en una suggest mia, la s me falla (también sos revisor de mis revisiones, podes leerlas, cambiarlas, discutirlas) y

y , pido disculpas, volví atrás la sugerencia timestamp. Habia buscado mal la primera referencia, está perfectamente definida al principio. Así que saqué la re-definicipon desprolija que hice más adelante.

javascript-translate-bot added needs +1 and removed review needed labels

Aug 19, 2020

Copy link

Collaborator

maksumi commentedAug 19, 2020•
edited
Loading

Estaba revisando este artículo pero no podré cumplir con él a buena hora. Par no detenerlo más, pido la ayuda de@vplentinax,@EzequielCaste o algún otro reviewer que se tome la molestia de venir por aquí, leer el comentario y quiera echar una manita de gato con esto. Mil gracias de antemano

vplentinax requested changes

Aug 27, 2020

View reviewed changes

Copy link

Contributor

vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pequeñas cositas, el resto correcto. Corregido esto, aprobamos.

1-js/05-data-types/11-date/article.md OutdatedShow resolvedHide resolved

1-js/05-data-types/11-date/2-get-week-day/solution.md OutdatedShow resolvedHide resolved

Copy link

javascript-translate-bot commentedAug 27, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label

Aug 27, 2020

Fedebornazand others added4 commits

August 27, 2020 22:26

Update 1-js/05-data-types/11-date/article.md

1147101

Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>

Update 1-js/05-data-types/11-date/article.md

f3bdfca

Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>

Update 1-js/05-data-types/11-date/article.md

63681a2

Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>

Update 1-js/05-data-types/11-date/2-get-week-day/solution.md

450593e

Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>

Copy link

ContributorAuthor

Fedebornaz commentedAug 28, 2020

Muchas gracias@vplentinax y@joaquinelio por tomarse el tiempo para hacer las reviews! Veo que la mayoría de las correcciones que me hicieron fueron typos, voy a investigar si hay alguna extensión de VSCode de corrector ortográfico que esté buena. Si tienen alguna otra herramienta que recomienden les agradezco!