- Notifications
You must be signed in to change notification settings - Fork230
Coordinates#349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Coordinates#349
Changes fromall commits
Commits
Show all changes
71 commits Select commitHold shift + click to select a range
b5e3cc5
Merge pull request #3 from javascript-tutorial/master
53e75b5
Merge pull request #4 from javascript-tutorial/master
d5ea01b
Merge pull request #5 from javascript-tutorial/master
cde00e0
Merge pull request #6 from javascript-tutorial/master
81e9cfd
Merge pull request #7 from javascript-tutorial/master
5402692
Update (#8)
16ccddf
Merge pull request #9 from javascript-tutorial/master
707db67
Update (#10)
5d7a154
Update (#11)
8c26be9
Merge pull request #13 from javascript-tutorial/master
371af05
Merge pull request #14 from javascript-tutorial/master
281ce34
Merge pull request #15 from javascript-tutorial/master
9328be8
Merge pull request #16 from javascript-tutorial/master
8210b40
Merge pull request #17 from javascript-tutorial/master
9c9f628
Merge pull request #18 from javascript-tutorial/master
c2728b4
Add files via upload
c1c77b6
Update task.md
712ee25
Update index.html
daa4e2e
Update 2-ui/1-document/11-coordinates/1-find-point-coordinates/soluti…
18c86b5
Apply suggestions from code review
2d26388
Update task.md
a0ce03f
Update 2-ui/1-document/11-coordinates/2-position-at/solution.md
vplentinax6ed3ab8
Update 2-ui/1-document/11-coordinates/1-find-point-coordinates/task.md
vplentinax173b33f
Update 2-ui/1-document/11-coordinates/1-find-point-coordinates/soluti…
vplentinax8b8edce
Update 2-ui/1-document/11-coordinates/1-find-point-coordinates/soluti…
vplentinax81f71b7
Update 2-ui/1-document/11-coordinates/1-find-point-coordinates/soluti…
vplentinax55f258c
Update 2-ui/1-document/11-coordinates/article.md
vplentinaxf3ea4b2
Update 2-ui/1-document/11-coordinates/article.md
vplentinax22c83e8
Update 2-ui/1-document/11-coordinates/article.md
vplentinaxe7c72a8
Update 2-ui/1-document/11-coordinates/article.md
vplentinaxce8912d
Update 2-ui/1-document/11-coordinates/article.md
vplentinax29f6934
Update 2-ui/1-document/11-coordinates/1-find-point-coordinates/soluti…
vplentinaxe80f5e5
Update 2-ui/1-document/11-coordinates/1-find-point-coordinates/task.md
vplentinaxa2b9c18
Update 2-ui/1-document/11-coordinates/2-position-at/solution.view/ind…
vplentinax84a0b84
Update 2-ui/1-document/11-coordinates/2-position-at/solution.view/ind…
vplentinax258d32d
Update 2-ui/1-document/11-coordinates/2-position-at/solution.view/ind…
vplentinax37eeb35
Update 2-ui/1-document/11-coordinates/2-position-at/solution.view/ind…
vplentinax7890137
Update 2-ui/1-document/11-coordinates/2-position-at/solution.view/ind…
vplentinaxc3b1668
Update 2-ui/1-document/11-coordinates/2-position-at/solution.view/ind…
vplentinax066cff9
Update 2-ui/1-document/11-coordinates/2-position-at/solution.view/ind…
vplentinax7357d41
Update 2-ui/1-document/11-coordinates/2-position-at/solution.view/ind…
vplentinax625dbad
Update 2-ui/1-document/11-coordinates/2-position-at/solution.view/ind…
vplentinaxc22725f
Update 2-ui/1-document/11-coordinates/2-position-at/source.view/index…
vplentinax1fe6863
Update 2-ui/1-document/11-coordinates/2-position-at/source.view/index…
vplentinax28628fa
Update 2-ui/1-document/11-coordinates/2-position-at/source.view/index…
vplentinax28bab5c
Update 2-ui/1-document/11-coordinates/2-position-at/source.view/index…
vplentinaxc7c75cf
Update 2-ui/1-document/11-coordinates/2-position-at/source.view/index…
vplentinax130c8b4
Update 2-ui/1-document/11-coordinates/2-position-at/source.view/index…
vplentinax4c6ed4d
Update 2-ui/1-document/11-coordinates/2-position-at/source.view/index…
vplentinax952d4cf
Update 2-ui/1-document/11-coordinates/2-position-at/source.view/index…
vplentinax491a080
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
vplentinax1bc20bd
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
vplentinax861b2e9
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
vplentinax1141d1c
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
vplentinax454ac36
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
vplentinaxde345d5
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
vplentinax4c9f381
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
vplentinaxdc59ce6
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
vplentinax1a823bb
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
vplentinax2015eae
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
vplentinaxf15a998
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
vplentinaxac0230b
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
vplentinaxab22501
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
vplentinaxc1a5d4e
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
vplentinaxdc115cc
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/solu…
vplentinax082548e
Update 2-ui/1-document/11-coordinates/4-position-inside-absolute/task.md
vplentinax49a83d5
Update 2-ui/1-document/11-coordinates/article.md
vplentinax3ac35a1
Update 2-ui/1-document/11-coordinates/article.md
vplentinax51e697a
Merge branch 'master' into coordinates
EzequielCaste8629435
Update 2-ui/1-document/11-coordinates/2-position-at/solution.view/ind…
EzequielCaste1262db8
Update 2-ui/1-document/11-coordinates/3-position-at-absolute/solution…
EzequielCasteFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
18 changes: 9 additions & 9 deletions2-ui/1-document/11-coordinates/1-find-point-coordinates/solution.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions2-ui/1-document/11-coordinates/1-find-point-coordinates/solution.view/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions2-ui/1-document/11-coordinates/1-find-point-coordinates/source.view/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
22 changes: 11 additions & 11 deletions2-ui/1-document/11-coordinates/1-find-point-coordinates/task.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions2-ui/1-document/11-coordinates/2-position-at/solution.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
En esta tarea sólo necesitamos calcular exactamente las coordenadas. Mira el código para más detalles. | ||
Ten en cuenta: los elementos deben estar en el documento para leer `offsetHeight`y otras propiedades. | ||
Un elemento oculto(`display:none`)o fuera del documentonotiene medidas. |
32 changes: 16 additions & 16 deletions2-ui/1-document/11-coordinates/2-position-at/solution.view/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
32 changes: 16 additions & 16 deletions2-ui/1-document/11-coordinates/2-position-at/source.view/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -12,10 +12,10 @@ | ||
esse sequi officia sapiente.</p> | ||
<blockquote> | ||
Maestra: Por qué llegas tarde? | ||
Alumno: Alguien perdió un billete de cien dólares. | ||
Maestra: Que bueno. Lo estábas ayudando a buscarlo? | ||
Alumno: No.Estaba parado encima del billete. | ||
</blockquote> | ||
<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit. Reprehenderit sint atque dolorum fuga ad incidunt voluptatum error fugiat animi amet! Odio temporibus nulla id unde quaerat dignissimos enim nisi rem provident molestias sit tempore omnis recusandae | ||
@@ -24,21 +24,21 @@ | ||
<script> | ||
/** | ||
*Posiciona elemen relación aanchorcomo se indica en position. | ||
* | ||
* @param {Node} anchorElemento anchor para posicionamiento | ||
* @param {string} positionCualquiera de los siguientes: top/right/bottom | ||
* @param {Node} elemElemento para position | ||
* | ||
*Ambos elementos: elemy anchordeben estar en el documento | ||
*/ | ||
function positionAt(anchor, position, elem) { | ||
// ...tu código ... | ||
} | ||
/** | ||
*Muestra una nota con elhtmlproporcionado en el lugar indicado por position | ||
*relativa al elemento anchor. | ||
*/ | ||
function showNote(anchor, position, html) { | ||
@@ -50,12 +50,12 @@ | ||
positionAt(anchor, position, note); | ||
} | ||
//¡Testealo! | ||
EzequielCaste marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
let blockquote = document.querySelector('blockquote'); | ||
showNote(blockquote, "top", "nota encima"); | ||
showNote(blockquote, "right", "nota a la derecha"); | ||
showNote(blockquote, "bottom", "nota debajo"); | ||
</script> | ||
16 changes: 8 additions & 8 deletions2-ui/1-document/11-coordinates/2-position-at/task.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -2,17 +2,17 @@ importance: 5 | ||
--- | ||
#Muestra una nota cercana al elemento | ||
Crea una función `positionAt(anchor, position, elem)`que posicione `elem`,dependiendo de la proximidad de`position`al elemento`anchor`. | ||
`position`debe ser un stringcon alguno de estos 3valores: | ||
- `"top"` -posiciona `elem`encima de `anchor` | ||
- `"right"` -posiciona `elem`inmediatamente a la derecha de `anchor` | ||
- `"bottom"` -posiciona `elem`debajo de `anchor` | ||
Esto será usado dentro de la función`showNote(anchor, position, html)`,proveída en el código fuente de la tarea, que crea un elemento"note"con el`html`y lo muestra en el lugar proporcionado por`position`cercano a `anchor`. | ||
joaquinelio marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
Aquí está eldemode las notas: | ||
[iframe src="solution" height="350" border="1" link] |
6 changes: 3 additions & 3 deletions2-ui/1-document/11-coordinates/3-position-at-absolute/solution.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
La solución realmente es muy simple: | ||
-Usa `position:absolute`con CSSen lugar de`position:fixed`para `.note`. | ||
-Usa la función [getCoords()](info:coordinates#getCoords)del capítulo<info:coordinates>para obtener las coordenadas relativas al documento. |
18 changes: 9 additions & 9 deletions2-ui/1-document/11-coordinates/3-position-at-absolute/solution.view/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -8,14 +8,14 @@ | ||
<body style="height: 2000px"> | ||
<p>El malvado Lord Vader, obsesionado por encontrar al joven Skywalker | ||
joaquinelio marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
esse sequi officia sapiente.</p> | ||
<blockquote> | ||
Maestra: Por qué llegas tarde? | ||
Alumno: Alguien perdió un billete de cien dólares. | ||
Maestra: Que bueno. Lo estábas ayudando a buscarlo? | ||
Alumno: No.Estaba parado encima del billete. | ||
</blockquote> | ||
<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit. Reprehenderit sint atque dolorum fuga ad incidunt voluptatum error fugiat animi amet! Odio temporibus nulla id unde quaerat dignissimos enim nisi rem provident molestias sit tempore omnis recusandae | ||
@@ -66,12 +66,12 @@ | ||
positionAt(anchor, position, note); | ||
} | ||
//¡Testéalo! | ||
let blockquote = document.querySelector('blockquote'); | ||
showNote(blockquote, "top", "nota encima"); | ||
showNote(blockquote, "right", "nota a la derecha"); | ||
showNote(blockquote, "bottom", "nota debajo"); | ||
</script> | ||
8 changes: 4 additions & 4 deletions2-ui/1-document/11-coordinates/3-position-at-absolute/task.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
17 changes: 9 additions & 8 deletions2-ui/1-document/11-coordinates/4-position-inside-absolute/solution.view/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.