Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Error handling with promises#329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

george28cs
Copy link
Contributor

Hola, envío el PR correspondiente a la traducción de "Manejo de errores con promesas".

@CLAassistant
Copy link

CLAassistant commentedJul 29, 2020•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@george28csgeorge28cs changed the titlepromises error handling v0promises error handlingJul 29, 2020
@joaquineliojoaquinelio changed the titlepromises error handlingError handling with promisesJul 29, 2020
@joaquineliojoaquinelio self-requested a reviewJuly 29, 2020 15:50
Copy link
Member

@joaquineliojoaquinelio left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@george28cs y reviewers
*Poco para corregir, no vi err de concepto,
ojalá un reviewer con más espalda JS que la mia lo mire...

*Tu PR está OK, Los archivos son los correctos y se ve muy bien.
*El nombre del PR debe ser exactamente (mayusc incluida) para que bot lo registre, nada grave, casi siempre lo modificamos a mano (cambié el nombre y actualicé el issue17).

NOTA: *Los arch originales inglés fueron modificados ayer y se generaron 2 conflictos:
Uno lo arreglé directamente en el traducido (el otro era gramatica inglés, no nos afecta)

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

george28csand others added5 commitsJuly 29, 2020 18:07
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@george28cs
Copy link
ContributorAuthor

/done

Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Lo veo bien...
a 2do reviewer, ¿es suficientemente clara la explicacion? promise, then, try, catch, y anidados...

Copy link
Contributor

@vplentinaxvplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Correcto, fluido.@joaquinelio , todos los conceptos se entienden bien.

@vplentinaxvplentinax merged commit2dfdbb3 intojavascript-tutorial:masterJul 31, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue#17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes

@vplentinaxvplentinaxvplentinax approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@george28cs@CLAassistant@javascript-translate-bot@joaquinelio@vplentinax
[8]ページ先頭
©2009-2025 Movatter.jp