Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Scripts: async, defer#324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
joaquinelio merged 26 commits intojavascript-tutorial:masterfromdbritto-dev:master
Jul 29, 2020

Conversation

dbritto-dev
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commentedJul 26, 2020•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@joaquineliojoaquinelio self-requested a reviewJuly 27, 2020 03:47
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Está bien, typos y tildes

podes aceptar, pelearme o ignorarme...
pero...
Creo que te ofreciste para review?
de los PR, con etiquetas "review needed", son los que no tuvieron revisión
o la tuvieron y el autor hizo/rechazó los cambios
Si está esperando "change req" no creo que valga la pena revisar, que el autor revise primero

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

dbritto-devand others added19 commitsJuly 27, 2020 00:02
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
dbritto-devand others added3 commitsJuly 27, 2020 00:48
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev
Copy link
ContributorAuthor

/done

Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok.
autor y/o 2do reviewer,
*clic para arreglar nro linea, algo menor
*No estoy convencido de la tabla en 185 (de origen), pero el evento y la relacion con los scripts se explican bien en el art.
Más que ok.

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev
Copy link
ContributorAuthor

/done

Copy link
Contributor

@vplentinaxvplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok!

@javascript-translate-bot

Thank you 💖 I updated the Progress Issue#17 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vplentinaxvplentinaxvplentinax approved these changes

@joaquineliojoaquinelioAwaiting requested review from joaquinelio

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@dbritto-dev@CLAassistant@javascript-translate-bot@joaquinelio@vplentinax
[8]ページ先頭
©2009-2025 Movatter.jp