Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Walking the DOM#318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Merged

Conversation

@Leired7
Copy link
Contributor

Artículo, task y soluciones traducido

@CLAassistant
Copy link

CLAassistant commentedJul 24, 2020•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@joaquineliojoaquinelio self-requested a reviewJuly 24, 2020 23:23
Copy link
Member

@joaquineliojoaquinelio left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Buena adición al repo,

algún typo,
algún cambio de construcción opinable (que podes ignorar y marcar resuelto)

Esstuve tentado a pedir algo más neutral de "una pega"
pero, argentino, la entendí, es perfecta.

Vamos segundo reviewer, ven a reviegüesear...

EDIT: nota, Don Segundo Reviewer: el bot no lo reconoció, lo agrego a mano. Arreglé el nombre supongo que con DOM mayúsculas lo verá cuando merge. Verificar...

Leired7 reacted with thumbs up emoji
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquineliojoaquinelio changed the titleWalking the domWalking the DOMJul 25, 2020
Copy link
Collaborator

@maksumimaksumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Muy buena traducción. Solo arreglar unos tipos y considerar algunas sugerencias para mantener un lenguaje simple en la traducción

Leired7 reacted with thumbs up emoji
Leired7and others added13 commitsJuly 27, 2020 07:46
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
…l/task.mdCo-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7Leired7 reopened thisJul 27, 2020
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7Leired7 reopened thisJul 27, 2020
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7
Copy link
ContributorAuthor

/done

@joaquinelio
Copy link
Member

@Leired7 ... ¿closed?
Supongo que ya estaba listo para última mirada e integrarlo,
¿puedo suponer que fue un error de "dóndehagoclicahora"? je je tuve muchos de esos cuando empecé con la traducción...

@Leired7
Copy link
ContributorAuthor

Síiii@joaquinelio!!!! exactamente paso eso! ¿Dónde "tengoqueclickarahora"?

@joaquinelio
Copy link
Member

No problem...
El autor puede cerrarlo para modificar sin que nadie lo moleste y reabrirlo o dejarlo cerrado y hacer uno nuevo, no pasa nada.
Acá abajo, "Reopen and comment"...
Pero como dijiste que fuer por error, me tenté y abro y reviso...

joaquinelioand others added2 commitsJuly 28, 2020 12:12
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Copy link
Member

@joaquineliojoaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No es perfecto, (sutilezas intraducibles)
pero menos será si hacemos de la redacción una asamblea.
Apliqué un par de sug de maksumi, dejé un par afuera, y otra que hice y no supe mejorar.
Funciona como está.

Leired7 reacted with laugh emojiLeired7 reacted with hooray emoji
@Leired7
Copy link
ContributorAuthor

Muchas gracias por la ayuda☺️@joaquinelio

@maksumi
Copy link
Collaborator

Merge it! Ya llegará el momento de detallar las sutilezas

@vplentinaxvplentinax merged commit9002711 intojavascript-tutorial:masterJul 29, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue#17 🎉 🎉 🎉

@Leired7
Copy link
ContributorAuthor

¡Qué alegría! jejej Gracias!!!

A por el siguiente....

joaquinelio, vplentinax, and maksumi reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@joaquineliojoaquineliojoaquinelio approved these changes

@maksumimaksumimaksumi approved these changes

+1 more reviewer

@dbritto-devdbritto-devdbritto-dev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Leired7@CLAassistant@javascript-translate-bot@joaquinelio@maksumi@dbritto-dev@vplentinax
[8]ページ先頭
©2009-2025 Movatter.jp