javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star608

Async/await#317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vplentinax merged 8 commits intojavascript-tutorial:masterfromjoaquinelio:asyawa

Jul 31, 2020

Merged

Async/await#317

vplentinax merged 8 commits intojavascript-tutorial:masterfromjoaquinelio:asyawa

Jul 31, 2020

Conversation

Copy link

Member

joaquinelio commentedJul 23, 2020

No description provided.

Async/await

2204f5e

javascript-translate-bot added the review needed label

Jul 23, 2020

javascript-translate-bot requested a review froma team

July 23, 2020 02:06

iliakan mentioned this pull request

Jul 23, 2020

Spanish Translation Progress#17

Open

dbritto-dev suggested changes

Jul 30, 2020

View reviewed changes

1-js/11-async/08-async-await/01-rewrite-async/solution.md OutdatedShow resolvedHide resolved

1-js/11-async/08-async-await/01-rewrite-async/task.md OutdatedShow resolvedHide resolved

1-js/11-async/08-async-await/03-async-from-regular/task.md OutdatedShow resolvedHide resolved

1-js/11-async/08-async-await/02-rewrite-async-2/solution.md OutdatedShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

Jul 30, 2020

Copy link

javascript-translate-bot commentedJul 30, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelioand others added6 commits

July 30, 2020 09:39

Update 1-js/11-async/08-async-await/01-rewrite-async/solution.md

f0e33f3

Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>

Update 1-js/11-async/08-async-await/01-rewrite-async/task.md

36ade9e

me da igual...Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>

Update 1-js/11-async/08-async-await/01-rewrite-async/task.md

0d4ae3d

Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>

Update 1-js/11-async/08-async-await/03-async-from-regular/task.md

2d7709d

ok, latin suena mejor que mal españolCo-authored-by: Danilo Britto <ddbn.c2@gmail.com>

Update 1-js/11-async/08-async-await/03-async-from-regular/task.md

e8f5a9e

¿por? se entiende, pero...Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>

Update 1-js/11-async/08-async-await/02-rewrite-async-2/solution.md

8d85031

Co-authored-by: Danilo Britto <ddbn.c2@gmail.com>

Copy link

MemberAuthor

joaquinelio commentedJul 30, 2020

/done

javascript-translate-bot added review needed and removed changes requested labels

Jul 30, 2020

Update task.md

46acfaa

s de mas linea 4maldito teclado

javascript-translate-bot removed the review needed label

Jul 30, 2020

maksumi approved these changes

Jul 30, 2020

View reviewed changes

javascript-translate-bot added the needs +1 label

Jul 30, 2020

maksumi approved these changes

Jul 30, 2020

View reviewed changes

Copy link

Collaborator

maksumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

¡Vientos!

vplentinax previously approved these changes

Jul 30, 2020

View reviewed changes

Copy link

Contributor

vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fuímonos! (pronombre enclítico)

vplentinax added ready to merge and removed needs +1 labels

Jul 30, 2020

Copy link

Contributor

vplentinax commentedJul 30, 2020

Bueno, realmente debí esperar que @danilobrinu aprobara los cambios. Retiro mi "fuímonos"!

vplentinax dismissed theirstale review

July 30, 2020 22:42

Other reviewer is here!

vplentinax added needs +1 and removed ready to merge labels

Jul 30, 2020

Copy link

Contributor

dbritto-dev commentedJul 30, 2020

@vplentinax jajaja aca estoy :p

Copy link

Contributor

vplentinax commentedJul 31, 2020•
edited
Loading

@vplentinax jajaja aca estoy :p

Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

Copy link

Contributor

dbritto-dev commentedJul 31, 2020•
edited
Loading

@vplentinax jajaja aca estoy :p
Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu

solo están los pasos para los mantenedores y los traductores, pero no he visto el de los revisores :(

Copy link

Contributor

vplentinax commentedJul 31, 2020

@vplentinax jajaja aca estoy :p
Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu
solo están los pasos para los mantenedores y los traductores, pero no he visto el de los revisores :(

Ok.

Ve a "Files Changed"
Comprueba que los cambios fueron aceptados, sugiere nuevos como lo hiciste ya, sino
Ve a la parte superior derecha, botón verde que pone "Review Changes", das click, se te despliega una lista, si estás de acuerdo con los cambios, eliges "Approve", dejas un comentario y listo.

Cualquier duda, nos avisas.

dbritto-dev approved these changes

Jul 31, 2020

View reviewed changes

Copy link

Contributor

dbritto-dev commentedJul 31, 2020

@vplentinax jajaja aca estoy :p
Aprueba los cambios si estás de acuerdo... sabes hacerlo¿?
@danilobrinu
solo están los pasos para los mantenedores y los traductores, pero no he visto el de los revisores :(
Ok.
Ve a "Files Changed"
Comprueba que los cambios fueron aceptados, sugiere nuevos como lo hiciste ya, sino
Ve a la parte superior derecha, botón verde que pone "Review Changes", das click, se te despliega una lista, si estás de acuerdo con los cambios, eliges "Approve", dejas un comentario y listo.
Cualquier duda, nos avisas.

@vplentinax listo 👍