javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star600

Basic operators, maths#314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

EzequielCaste merged 15 commits intojavascript-tutorial:masterfromEzequielCaste:math-basic-operators

Jul 23, 2020

Merged

Basic operators, maths#314

EzequielCaste merged 15 commits intojavascript-tutorial:masterfromEzequielCaste:math-basic-operators

Jul 23, 2020

Conversation

Copy link

Contributor

EzequielCaste commentedJul 22, 2020

No description provided.

traducción completa de 08 operators

5b36995

EzequielCaste requested a review fromvplentinax

July 22, 2020 15:14

javascript-translate-bot added the review needed label

Jul 22, 2020

javascript-translate-bot requested a review froma team

July 22, 2020 15:14

EzequielCaste changed the title~~traducción completa de 08 operators~~Basic operators, maths

Jul 22, 2020

iliakan mentioned this pull request

Jul 22, 2020

Spanish Translation Progress#17

Open

joaquinelio self-requested a review

July 22, 2020 19:14

joaquinelio requested changes

Jul 22, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

¡Uh, miren quén está vivo!
¿Un año sabático de un par de dias?
qué perezoso

Con este aporte casi se lee de corrido la primera parte!!!!!!
salvo el exmantainer ric

edit:
ah, no da para review, pero la version inglés 1 2 8 3 solution,
hacen "fix" (¿?) agregan ESPACIOS en lineas 13 y 14... NO ENTIEDO POR QUÉ

edit2:
No está basado en el EN de hace 3 meses
cambia def, titulos y agrega algunas linas al articulo

1-js/02-first-steps/08-operators/1-increment-order/solution.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/08-operators/1-increment-order/task.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/08-operators/3-primitive-conversions-questions/solution.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/08-operators/3-primitive-conversions-questions/task.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/08-operators/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

Jul 22, 2020

Copy link

javascript-translate-bot commentedJul 22, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCasteand others added10 commits

July 22, 2020 19:16

Update 1-js/02-first-steps/08-operators/1-increment-order/solution.md

7d34563

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/08-operators/1-increment-order/solution.md

a11a915

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/08-operators/1-increment-order/task.md

500d8e5

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/08-operators/3-primitive-conversions-quest…

b14e252

…ions/solution.mdCo-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/08-operators/3-primitive-conversions-quest…

ef70003

…ions/task.mdCo-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/08-operators/article.md

0b01e8b

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/08-operators/article.md

3fb8d40

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/08-operators/article.md

5a008f3

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/08-operators/article.md

01716b7

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/08-operators/article.md

470f5f8

Copy link

ContributorAuthor

EzequielCaste commentedJul 22, 2020

/done

javascript-translate-bot added review needed and removed changes requested labels

Jul 22, 2020

javascript-translate-bot requested a review froma team

July 22, 2020 22:22

EzequielCaste removed request fora team andvplentinax

July 23, 2020 00:02

Update 1-js/02-first-steps/08-operators/article.md

4104623

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

joaquinelio approved these changes

Jul 23, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

NO LO RELEÍ apenass miré lo que puso maksumi.
Supongo que arreglaste los tipos,
y solo te disscutiría los err de concepto pero no había visto ninguno, so...
apruebo sin leer.

javascript-translate-bot removed the review needed label

Jul 23, 2020

javascript-translate-bot added the needs +1 label

Jul 23, 2020

maksumi approved these changes

Jul 23, 2020

View reviewed changes

Copy link

Collaborator

maksumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Solo hay unas nuevas sugerencias que veo necesarias, consideralaspor favor. De ahí en fuera: approve!

1-js/02-first-steps/08-operators/1-increment-order/solution.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/08-operators/3-primitive-conversions-questions/solution.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/08-operators/4-fix-prompt/solution.md


		```js run
		let a = "1"; // prompt("First number?", 1);
		let b = "2"; // prompt("Second number?", 2);
		let a = "1"; // prompt("Primer número?", 1);

Copy link

Collaborator

maksumiJul 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

De hecho no... Leelo con tono de pregunta.@joaquinelio

EzequielCasteand others added3 commits

July 23, 2020 09:38

Update 1-js/02-first-steps/08-operators/1-increment-order/solution.md

fa1f7d2

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Update 1-js/02-first-steps/08-operators/1-increment-order/solution.md

b83d4b1

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Update 1-js/02-first-steps/08-operators/3-primitive-conversions-quest…

ec1088a

…ions/solution.mdCo-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

EzequielCaste merged commit33f3ea4 intojavascript-tutorial:master

Jul 23, 2020

Copy link

javascript-translate-bot commentedJul 23, 2020

Thank you 💖 I updated the Progress Issue#17 🎉 🎉 🎉

Labels

needs +1

4 participants

Movatterモバイル変換

Basic operators, maths#314

Basic operators, maths#314

Uh oh!

Conversation

EzequielCaste commentedJul 22, 2020

Uh oh!

joaquinelio left a comment• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedJul 22, 2020

Uh oh!

EzequielCaste commentedJul 22, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

maksumi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maksumiJul 23, 2020

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commentedJul 23, 2020

Uh oh!

Uh oh!

joaquinelio left a comment•
edited
Loading