javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star601

JSON methods, toJSON#278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

EzequielCaste merged 18 commits intojavascript-tutorial:masterfromEzequielCaste:json-methods

Jul 13, 2020

Merged

JSON methods, toJSON#278

EzequielCaste merged 18 commits intojavascript-tutorial:masterfromEzequielCaste:json-methods

Jul 13, 2020

Conversation

Copy link

Contributor

EzequielCaste commentedJun 22, 2020

actualizados los nombres de archivos

traducción json methods

08509de

EzequielCaste requested a review fromvplentinax

June 22, 2020 23:19

javascript-translate-bot added the review needed label

Jun 22, 2020

javascript-translate-bot requested a review froma team

June 22, 2020 23:19

iliakan mentioned this pull request

Jun 22, 2020

Spanish Translation Progress#17

Open

joaquinelio requested changes

Jul 6, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

http://tools.ietf.org/html/rfc4627 no anda, pero el nombre está registrado quizas sea temporal

¿corrijo los signos de apertura? Español exige simetría ¿¿¡¡!!?? salvo ¡¡?? y (?)

1-js/05-data-types/12-json/2-serialize-event-circular/task.md OutdatedShow resolvedHide resolved

1-js/05-data-types/12-json/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot removed the review needed label

Jul 6, 2020

Copy link

javascript-translate-bot commentedJul 6, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label

Jul 6, 2020

EzequielCasteand others added12 commits

July 8, 2020 09:00

Update 1-js/05-data-types/12-json/2-serialize-event-circular/task.md

67cf345

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

bef3826

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

77d8205

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

816e630

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

b7f2e14

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

222b916

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

c7e2b99

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

c523264

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

bff4acd

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

eb3c914

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

6c398c1

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

7e2be2b

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

EzequielCaste commented

Jul 8, 2020

View reviewed changes

Copy link

ContributorAuthor

EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

correcciones

EzequielCaste removed the request for review fromvplentinax

July 8, 2020 12:16

Copy link

ContributorAuthor

EzequielCaste commentedJul 11, 2020

/done

javascript-translate-bot added review needed and removed changes requested labels

Jul 11, 2020

javascript-translate-bot requested a review froma team

July 11, 2020 15:04

joaquinelio requested changes

Jul 12, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"request" para label correcto,
cosass menores, desp de eso que el 2do reviewer considere que lo apprové

Si le interesa a alguien, "there is no..." a veces se traduce "no está permitido".
No sé si es inglés general o una particcularidad yanqui
"There is no walking in the red zone"

1-js/05-data-types/12-json/article.md OutdatedShow resolvedHide resolved

1-js/05-data-types/12-json/article.mdShow resolvedHide resolved

1-js/05-data-types/12-json/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot removed the review needed label

Jul 12, 2020

Copy link

javascript-translate-bot commentedJul 12, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label

Jul 12, 2020

EzequielCasteand others added5 commits

July 13, 2020 09:08

Update 1-js/05-data-types/12-json/article.md

5f21aa8

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

28fb630

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

91ab19c

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

e63a07c

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/12-json/article.md

3084859

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Copy link

ContributorAuthor

EzequielCaste commentedJul 13, 2020

/done

javascript-translate-bot added review needed and removed changes requested labels

Jul 13, 2020

javascript-translate-bot requested a review froma team

July 13, 2020 12:15

EzequielCaste commented

Jul 13, 2020

View reviewed changes

Copy link

ContributorAuthor

EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link

ContributorAuthor

EzequielCaste commentedJul 13, 2020

/done

EzequielCaste removed the request for review froma team

July 13, 2020 12:20

Copy link

ContributorAuthor

EzequielCaste commentedJul 13, 2020

alguien tiene que "Aprobar" para seguir el procedimiento..
@joaquinelio vos pedís cambios yo los hago, tenés que aprobar los cambios que hice.

Copy link

Member

joaquinelio commentedJul 13, 2020

alguien tiene que "Aprobar" para seguir el procedimiento..
@joaquinelio vos pedís cambios yo los hago, tenés que aprobar los cambios que hice.

@ezzep66
Pfff reglas, reglas, reglas,
o el dedo que apunta a la luna, ¿lo que importa es el dedo? 😄

seriamente,
veras que apruuebo todo lo que veo terminado,
pero dejo el mensaje para alentarlos a obviar el paso robótico nomás, no porque no haya cumplido mi parte de review.
Si fuera código sería mucho más estricto.

joaquinelio approved these changes

Jul 13, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

javascript-translate-bot added needs +1 and removed review needed labels

Jul 13, 2020

EzequielCaste merged commit29b4499 intojavascript-tutorial:master

Jul 13, 2020

Copy link

javascript-translate-bot commentedJul 13, 2020

Thank you 💖 I updated the Progress Issue#17 🎉 🎉 🎉

Labels

needs +1

3 participants

Movatterモバイル変換

JSON methods, toJSON#278

JSON methods, toJSON#278

Uh oh!

Conversation

EzequielCaste commentedJun 22, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedJul 6, 2020

Uh oh!

EzequielCaste left a comment

Choose a reason for hiding this comment

Uh oh!

EzequielCaste commentedJul 11, 2020

Uh oh!

joaquinelio left a comment• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedJul 12, 2020

Uh oh!

EzequielCaste commentedJul 13, 2020

Uh oh!

EzequielCaste left a comment

Choose a reason for hiding this comment

Uh oh!

EzequielCaste commentedJul 13, 2020

Uh oh!

EzequielCaste commentedJul 13, 2020

Uh oh!

joaquinelio commentedJul 13, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commentedJul 13, 2020

Uh oh!

Uh oh!

joaquinelio left a comment•
edited
Loading