Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Map and Set#263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vplentinax merged 24 commits intojavascript-tutorial:masterfromvplentinax:mset
Jul 5, 2020
Merged

Map and Set#263

vplentinax merged 24 commits intojavascript-tutorial:masterfromvplentinax:mset
Jul 5, 2020

Conversation

vplentinax
Copy link
Contributor

Arreglado los errores de formato.

Copy link
Contributor

@EzequielCasteEzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hay error al comienzo de 1-js/05-data-types/07-map-set/02-filter-anagrams/solution.md
No se ha respetado los números de las líneas. Debe comenzar en línea N° 1 y no en la N°2.

Por favor corregir así puedo seguir con la revisión.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

arreglé el problema de los espacios.Por favor tienen que coincidir los números de las líneas con el documento Original.
problemas con la numeración de líneas
número de líneas
respetar el número de línea
Copy link
Contributor

@EzequielCasteEzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

muchos problemas con espacios donde no deberían estar.
Se debe respetar el número de línea del documento original.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinaxand others added12 commitsJuly 4, 2020 19:15
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
vplentinaxand others added5 commitsJuly 4, 2020 19:18
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax
Copy link
ContributorAuthor

/done

@vplentinaxvplentinax merged commit6249f2a intojavascript-tutorial:masterJul 5, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue#17 🎉 🎉 🎉

@joaquinelio
Copy link
Member

joaquinelio commentedJul 5, 2020
edited
Loading

@vplentinax@ezzep66
¿Merged? Lo tenía recién en una pestaña para revisión...
Estoy de ACUERDO con los merge aprobados por la trusted people, (después de la carga, revisar el repo entero)
¿pero qué pasó con eso del doble review que pide don Bot?
No me quejo, es saber cuál es el criterio.

@vplentinax
Copy link
ContributorAuthor

En mis PR el segundo review lo doy yo jejeje.

joaquinelio reacted with thumbs up emojijoaquinelio reacted with rocket emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@EzequielCasteEzequielCasteEzequielCaste approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@vplentinax@javascript-translate-bot@joaquinelio@EzequielCaste

[8]ページ先頭

©2009-2025 Movatter.jp