javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star601

Symbol type#252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vplentinax merged 10 commits intojavascript-tutorial:masterfromvplentinax:mariadp-symbol-type

Jul 5, 2020

Merged

Symbol type#252

vplentinax merged 10 commits intojavascript-tutorial:masterfromvplentinax:mariadp-symbol-type

Jul 5, 2020

Conversation

Copy link

Contributor

vplentinax commentedJun 13, 2020

Este PR corresponde a la traducción del PRSymbol type #115 hecho por la usuaria@mariapb. Revisar.Dicho PR#115 será cerrado y editado en el Issue#17

mariabp-translate-symbol

98ad04b

javascript-translate-bot added the review needed label

Jun 13, 2020

javascript-translate-bot requested a review froma team

June 13, 2020 18:44

iliakan mentioned this pull request

Jun 13, 2020

Spanish Translation Progress#17

Open

javascript-tutorial deleted a comment fromjavascript-translate-bot

Jun 13, 2020

cortizg suggested changes

Jun 13, 2020

View reviewed changes

1-js/04-object-basics/08-symbol/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot removed the review needed label

Jun 13, 2020

Copy link

javascript-translate-bot commentedJun 13, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label

Jun 13, 2020

cortizg suggested changes

Jun 13, 2020

View reviewed changes

Copy link

Contributor

cortizg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Algunas observaciones

1-js/04-object-basics/08-symbol/article.md OutdatedShow resolvedHide resolved

Copy link

javascript-translate-bot commentedJun 13, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelio requested changes

Jun 14, 2020

View reviewed changes

1-js/04-object-basics/08-symbol/article.md OutdatedShow resolvedHide resolved

1-js/04-object-basics/08-symbol/article.md Outdated

		name: "John"
		};

		let id = Symbol("id");

		user[id] = 1;

		alert( user[id] ); //we can access the data using thesymbolas the key
		alert( user[id] ); //podemos accesar a la información utilizandosymbolcomo propiedad

Copy link

Member

joaquinelioJun 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	alert( user[id] ); // podemos accesar a la información utilizando symbol comopropiedad
	alert( user[id] ); // podemos accesar a la información utilizando elsymbol comoclave

1-js/04-object-basics/08-symbol/article.md OutdatedShow resolvedHide resolved

Copy link

javascript-translate-bot commentedJun 14, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinaxand others added3 commits

June 16, 2020 12:09

Update 1-js/04-object-basics/08-symbol/article.md

b86bda1

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/08-symbol/article.md

b9fead4

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/08-symbol/article.md

9fc3ad4

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Copy link

ContributorAuthor

vplentinax commentedJun 16, 2020

/done

javascript-translate-bot added review needed and removed changes requested labels

Jun 16, 2020

javascript-translate-bot requested a review froma team

June 16, 2020 16:11

joaquinelio requested changes

Jul 2, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@vplentinax @ezzep66 @cortizg
Al toro por las... y seguir adelante.

En este particular artículo queda evidente que no va "key = property",
se confunde el nombre con la cosa o la llave con la caja, escribir propiedad/valor lleva a definición circular, son categorías diferentes y, ej: Mientras prop puede ser un boolean, key no.

En la mayoría de las referencias la distinción es superflua y puede pasar aunque no me guste, aunque acá la necesitamos.
Pero estaría mal usar "clave" si no se usa en el resto del curso. Así que refiguro
key (nombre de propiedad) / value (valor de propiedad)

Creo que el artículo quedó entendible. Si quieren cambiar, ok, me salgo de la discusión y sigo aportando con otras reviews. Que no nos frene.
FESTEJEMOS EL TERCIO DE REPO TRADUCIDO

NOTA: Quise añadir las sugerencias de c4 y no pude ¿como se hace suggest de una línea no traducida? Hay //comments no traducidos.

1-js/04-object-basics/08-symbol/article.md OutdatedShow resolvedHide resolved

1-js/04-object-basics/08-symbol/article.md Outdated


		By specification, object property keys may be either of string type, or of symbol type. Not numbers, not booleans, only strings or symbols, these two types.
		Por especificación, las claves de un objeto deben ser solamente del tipo String o Symbol. Solamente esos dos: String o Symbol.

Copy link

Member

joaquinelioJul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	Por especificación,las claves de un objeto deben ser solamente del tipo String o Symbol. Solamente esos dos: String o Symbol.
	Por especificación,los nombres de propiedad (keys) de un objeto deben ser solamente del tipo String o Symbol. Solamente esos dos: String o Symbol.

1-js/04-object-basics/08-symbol/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

Jul 2, 2020

Copy link

javascript-translate-bot commentedJul 2, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinaxand others added6 commits

July 2, 2020 17:59

Update 1-js/04-object-basics/08-symbol/article.md

c9b24e3

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/08-symbol/article.md

adef69b

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/08-symbol/article.md

da63be3

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/08-symbol/article.md

ec2a0de

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/08-symbol/article.md

d95aaa5

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update article.md

5236768

En el glosario se estipuló key = clave. Así lo dejo y dejaré en próximas traducciones.

Copy link

ContributorAuthor

vplentinax commentedJul 2, 2020

/done

javascript-translate-bot added review needed and removed changes requested labels

Jul 2, 2020

javascript-translate-bot requested a review froma team

July 2, 2020 22:33

javascript-translate-bot removed the review needed label

Jul 3, 2020

joaquinelio approved these changes

Jul 3, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@vplentinax

En el glosario se estipuló key = clave. Así lo dejo y dejaré en próximas traducciones.

¡De acuerdo!
Pero... Algo me perdí, insistí con clave pero me había cansado... Recuerdo la argumentacipn de eze sobre propiedad/valor, del ctl+F y el cuenta palabbras, deque era como se lo enseñaron...
Y veo qye lo repusiste< ¡hace dos semanas!

clave, perfecto. Es la llave con la que se accede al value de la propiedad.

javascript-translate-bot added the needs +1 label

Jul 3, 2020

vplentinax merged commitd0b203c intojavascript-tutorial:master

Jul 5, 2020

Copy link

javascript-translate-bot commentedJul 5, 2020

Error: the article has another translator@mariabp, not@vplentinax in the Progress Issue#17. Please update the progress issue or ask maintainers to do so.

Labels

needs +1

4 participants

Movatterモバイル変換

Symbol type#252

Symbol type#252

Uh oh!

Conversation

vplentinax commentedJun 13, 2020

Uh oh!

Uh oh!

javascript-translate-bot commentedJun 13, 2020

Uh oh!

cortizg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedJun 13, 2020

Uh oh!

Uh oh!

joaquinelioJun 14, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

javascript-translate-bot commentedJun 14, 2020

Uh oh!

vplentinax commentedJun 16, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joaquinelioJul 2, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

javascript-translate-bot commentedJul 2, 2020

Uh oh!

vplentinax commentedJul 2, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commentedJul 5, 2020

Uh oh!

Uh oh!