javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star601

Conditional operators: if, '?'#231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

EzequielCaste merged 37 commits intojavascript-tutorial:masterfromvplentinax:Giorgiosaud-conditional-if

Jun 20, 2020

Merged

Conditional operators: if, '?'#231

EzequielCaste merged 37 commits intojavascript-tutorial:masterfromvplentinax:Giorgiosaud-conditional-if

Jun 20, 2020

Conversation

Copy link

Contributor

vplentinax commentedJun 5, 2020

Este PR es la corrección al articulo traducido por el colaboradorGiorgiosaud Conditional if#95 . Dicho PR será cerrado y reenumerado en el Issue 17.

pr-95-Giorgiosaud-correction

6941a56

javascript-translate-bot added the review needed label

Jun 5, 2020

javascript-translate-bot requested a review froma team

June 5, 2020 18:23

iliakan mentioned this pull request

Jun 5, 2020

Spanish Translation Progress#17

Open

vplentinax requested review fromEzequielCaste andjoaquinelio

June 5, 2020 18:25

Copy link

Member

joaquinelio commentedJun 5, 2020•
edited
Loading

Les recuerdo, acá el giorgio editó los SVG.
No se editan, hay un procedimiento parametrizado para traducirlos.

joaquinelio previously requested changes

Jun 14, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Si corrigen la ortografía que sugerí,
que el segundo reviewer que haga el merge

1-js/02-first-steps/10-ifelse/article.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/10-ifelse/2-check-standard/task.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/10-ifelse/5-rewrite-if-question/task.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/10-ifelse/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

Jun 14, 2020

Copy link

javascript-translate-bot commentedJun 14, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinaxand others added19 commits

June 16, 2020 12:11

Update 1-js/02-first-steps/10-ifelse/article.md

e9b7747

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

c72776f

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

1c10a2b

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

643b511

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

26f6448

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

dfe7d40

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

7977b4a

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/2-check-standard/task.md

e2bb1ec

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/5-rewrite-if-question/task.md

0bb1510

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

adefcea

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

10bdedb

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

50ed670

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

fc95df9

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

d6686c0

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

96c3ae7

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

341830f

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

fbbb9c0

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

a29d26e

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

18cac2f

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

vplentinaxand others added6 commits

June 16, 2020 12:18

Update 1-js/02-first-steps/10-ifelse/article.md

f3a2697

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

a589360

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

c477d72

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

1848326

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

a76a61c

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/10-ifelse/article.md

0953da0

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Copy link

ContributorAuthor

vplentinax commentedJun 16, 2020

/done

javascript-translate-bot added review needed and removed changes requested labels

Jun 16, 2020

javascript-translate-bot requested a review froma team

June 16, 2020 16:30

EzequielCaste requested changes

Jun 20, 2020

View reviewed changes

1-js/02-first-steps/10-ifelse/1-if-zero-string/solution.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/10-ifelse/1-if-zero-string/task.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/10-ifelse/2-check-standard/ifelse_task2/index.html OutdatedShow resolvedHide resolved

1-js/02-first-steps/10-ifelse/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot removed the review needed label

Jun 20, 2020

Copy link

javascript-translate-bot commentedJun 20, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label

Jun 20, 2020

EzequielCaste added10 commits

June 20, 2020 18:47

Update 1-js/02-first-steps/10-ifelse/1-if-zero-string/solution.md

5f314c6

Update 1-js/02-first-steps/10-ifelse/1-if-zero-string/solution.md

738f22f

Update 1-js/02-first-steps/10-ifelse/1-if-zero-string/task.md

ac725a5

Update 1-js/02-first-steps/10-ifelse/1-if-zero-string/task.md

49f1dfe

Update 1-js/02-first-steps/10-ifelse/2-check-standard/ifelse_task2/in…

ffde1eb

…dex.html

Update 1-js/02-first-steps/10-ifelse/article.md

38b09b4

Update 1-js/02-first-steps/10-ifelse/article.md

36b9977

Update 1-js/02-first-steps/10-ifelse/article.md

5c02c93

Update 1-js/02-first-steps/10-ifelse/article.md

22388e4

Update 1-js/02-first-steps/10-ifelse/article.md

438d1b9

EzequielCaste approved these changes

Jun 20, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed changes requested labels

Jun 20, 2020

EzequielCaste dismissedjoaquinelio’sstale review

June 20, 2020 21:53

already approved by@ezzep66

EzequielCaste merged commitcb0982e intojavascript-tutorial:master

Jun 20, 2020

EzequielCaste removed the needs +1 label

Jun 20, 2020

Labels

None yet

4 participants

Movatterモバイル変換

Conditional operators: if, '?'#231

Conditional operators: if, '?'#231

Uh oh!

Conversation

vplentinax commentedJun 5, 2020

Uh oh!

joaquinelio commentedJun 5, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedJun 14, 2020

Uh oh!

vplentinax commentedJun 16, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedJun 20, 2020

Uh oh!

Uh oh!

joaquinelio commentedJun 5, 2020•
edited
Loading