javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star600

Functions#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vplentinax merged 31 commits intojavascript-tutorial:masterfromvplentinax:Giorgiosaud-function-basics

Jul 3, 2020

Merged

Functions#230

vplentinax merged 31 commits intojavascript-tutorial:masterfromvplentinax:Giorgiosaud-function-basics

Jul 3, 2020

Conversation

Copy link

Contributor

vplentinax commentedJun 5, 2020•
edited
Loading

Este PR es la corrección al articulo traducido por el colaboradorGiorgiosaud Functions#96 . Dicho PR será cerrado y reenumerado en el Issue 17.

Giorgiosaud-PR95-correccion

76be9f6

javascript-translate-bot added the review needed label

Jun 5, 2020

javascript-translate-bot requested a review froma team

June 5, 2020 17:34

vplentinax changed the title~~Giorgiosaud-PR95-correccion~~Conditional operators: if, '?'

Jun 5, 2020

iliakan mentioned this pull request

Jun 5, 2020

Spanish Translation Progress#17

Open

vplentinax requested review fromEzequielCaste andjoaquinelio

June 5, 2020 17:38

vplentinax changed the title~~Conditional operators: if, '?'~~Functions

Jun 5, 2020

EzequielCaste requested changes

Jun 15, 2020

View reviewed changes

Copy link

Contributor

EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

casi listo, algunas correcciones

1-js/02-first-steps/15-function-basics/1-if-else-required/task.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/15-function-basics/2-rewrite-function-question-or/task.md OutdatedShow resolvedHide resolved

1-js/02-first-steps/15-function-basics/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

Jun 15, 2020

Copy link

javascript-translate-bot commentedJun 15, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCasteand others added16 commits

June 15, 2020 11:05

Update 1-js/02-first-steps/15-function-basics/1-if-else-required/task.md

f95071e

Update 1-js/02-first-steps/15-function-basics/2-rewrite-function-ques…

09ffe2a

…tion-or/task.md

Update 1-js/02-first-steps/15-function-basics/article.md

70b78b8

Update 1-js/02-first-steps/15-function-basics/article.md

bdfa86a

Update 1-js/02-first-steps/15-function-basics/article.md

f92cde2

Update 1-js/02-first-steps/15-function-basics/article.md

71c8b5f

Update 1-js/02-first-steps/15-function-basics/article.md

37463e9

Update 1-js/02-first-steps/15-function-basics/article.md

70e926b

Update 1-js/02-first-steps/15-function-basics/article.md

03bc402

Update 1-js/02-first-steps/15-function-basics/article.md

d5c47ee

Update 1-js/02-first-steps/15-function-basics/article.md

f6655c0

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>

Update 1-js/02-first-steps/15-function-basics/article.md

023b516

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>

Update 1-js/02-first-steps/15-function-basics/article.md

25dfc7f

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>

Update 1-js/02-first-steps/15-function-basics/article.md

f4e78a7

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>

Update 1-js/02-first-steps/15-function-basics/article.md

d944b06

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>

Update 1-js/02-first-steps/15-function-basics/article.md

6e08312

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>

Copy link

ContributorAuthor

vplentinax commentedJun 16, 2020

/done

javascript-translate-bot removed the changes requested label

Jun 16, 2020

javascript-translate-bot added the review needed label

Jun 16, 2020

javascript-translate-bot requested a review froma team

June 16, 2020 16:36

joaquinelio reviewed

Jul 2, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

varios cambiecitos
Pero muy buen schooling, sodont wait for me
cambia lo que quieras y MERGE

Partimos de un falso "mucho hecho", resignamos a que eran menos de 20.
Ahora 60... ¡UN TERCIO DEL SITIO! Y los PR, dentro del mes.
Qué sino para festejo.

1-js/02-first-steps/15-function-basics/article.md OutdatedShow resolvedHide resolved

vplentinaxand others added14 commits

July 2, 2020 17:51

Update 1-js/02-first-steps/15-function-basics/article.md

05538ed

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/15-function-basics/article.md

bd731dc

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/15-function-basics/article.md

7312c8f

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/15-function-basics/article.md

06a0d8f

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/15-function-basics/article.md

3dde6f3

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/15-function-basics/article.md

22dec62

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/15-function-basics/article.md

7776d6e

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/15-function-basics/article.md

fb1b96f

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/15-function-basics/article.md

86af996

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/15-function-basics/article.md

5b73d94

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/15-function-basics/article.md

b889666

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/15-function-basics/article.md

ca8c18d

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/15-function-basics/article.md

9f1b86d

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/02-first-steps/15-function-basics/article.md

bd45ddd

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Copy link

ContributorAuthor

vplentinax commentedJul 2, 2020

/done

javascript-translate-bot requested a review froma team

July 2, 2020 21:55

joaquinelio approved these changes

Jul 3, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Jul 3, 2020

vplentinax merged commitca8f297 intojavascript-tutorial:master

Jul 3, 2020

Copy link

javascript-translate-bot commentedJul 3, 2020

Error: the article has another translator@Giorgiosaud, not@vplentinax in the Progress Issue#17. Please update the progress issue or ask maintainers to do so.

Labels

needs +1

4 participants

Movatterモバイル変換

Functions#230

Functions#230

Uh oh!

Conversation

vplentinax commentedJun 5, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

EzequielCaste left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedJun 15, 2020

Uh oh!

vplentinax commentedJun 16, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vplentinax commentedJul 2, 2020

Uh oh!

javascript-translate-bot commentedJul 3, 2020

Uh oh!

Uh oh!

vplentinax commentedJun 5, 2020•
edited
Loading