javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star600

Prototype methods, objects without proto#195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vplentinax merged 6 commits intojavascript-tutorial:masterfromcortizg:es.javascript.info.1-08-04-pm

Jun 3, 2020

Merged

Prototype methods, objects without proto#195

vplentinax merged 6 commits intojavascript-tutorial:masterfromcortizg:es.javascript.info.1-08-04-pm

Jun 3, 2020

Conversation

Copy link

Contributor

cortizg commentedMay 18, 2020

No description provided.

javascript-translate-bot added the review needed label

May 18, 2020

javascript-translate-bot requested a review froma team

May 18, 2020 01:26

iliakan mentioned this pull request

May 18, 2020

Spanish Translation Progress#17

Open

1-08-04-pm Traducido 15

d96e8e1

1-08-04-pm Corregido 141-08-04-pm Corregido 15

joaquinelio requested changes

May 25, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Bien, sugiero el rearmado de algunas frases.

no se si se debe modificar
index.md (se usa como link, aunque también para mostrar menú)
los svg (y que no sé cómo probar desde acá) creo haber leído que se llaman con parámetros y no se debían modificar pero no pude encontrar dónde.

1-js/08-prototypes/04-prototype-methods/2-dictionary-tostring/task.md OutdatedShow resolvedHide resolved

1-js/08-prototypes/04-prototype-methods/article.md OutdatedShow resolvedHide resolved

1-js/08-prototypes/04-prototype-methods/2-dictionary-tostring/task.md OutdatedShow resolvedHide resolved

1-js/08-prototypes/04-prototype-methods/article.md OutdatedShow resolvedHide resolved

1-js/08-prototypes/04-prototype-methods/article.md Outdated


		```js
		//fully identical shallow clone of obj
		//clon superficial totalmente idéntico de obj

Copy link

Member

joaquinelioMay 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

no entiendo por qué puso shallow, es obj es simplemente "idéntico", nada más. salvo que signifique copia llana. no lo pondría. Tembién me molesta la redundancia del original, pero lo quiere sobresalir de la copia via loop que sí es superficial.

// clon totalmente idéntico de obj

Copy link

ContributorAuthor

cortizgMay 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link

Contributor

EzequielCasteMay 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"shallow" es para identificar que no tiene objetos anidados en su interior

Copy link

Member

joaquinelioMay 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

¡AAAGGH!
DISCULPEN la falta de atención. metí un err donde no lo había
Debería poner un PR al inglés, poque "idéntico" confunde,
hay obj copiados superficialmente (es CORRECTA la palabra) por lo tanto NO idénticos,
y obj copiados recursivamente , IDÉNTICO y no superficial , creí que se refería a esto

Copy link

ContributorAuthor

cortizgMay 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

¿seria entonces: clon superficial totalmente idéntico a obj?

Copy link

Member

joaquinelioMay 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

PFFF
si yo estuviera estudiando esto, abandonaría

quizas sea que la capa superficial sí es idéntica
(porque podrías copiar solo prop y metodos y dejar sin copiar el resto)

No me animo a corregir, tengo que repasar el tema. Haciendo pruebas.
@ezzep66 sí parece entenderlo

Copy link

Contributor

EzequielCasteMay 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fully identical >> totalmente idéntico
shallow clone >> clon superficial
of obj >> de obj

clon superficial de obj totalmente idéntico
me parece...

Copy link

ContributorAuthor

cortizgMay 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ok: clon superficial de obj totalmente idéntico

1-js/08-prototypes/04-prototype-methods/article.md OutdatedShow resolvedHide resolved

1-js/08-prototypes/04-prototype-methods/article.md Outdated


		The built-in`__proto__`getter/setter is unsafe if we'd want to put user-generated keys in to an object. Just because a user may enter "__proto__" as the key, and there'll be anerror with hopefully easy, but generally unpredictable consequences.
		El getter/setter incorporado de`__proto__`no es seguro si queremos poner claves generadas por el usuario en un objeto. Aunque un usuario puede ingresar `"__proto __"` como clave, y habrá unerror, con consecuencias levemente esperanzadoras, pero generalmente impredecibles.

Copy link

Member

joaquinelioMay 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

( ) , y habrá un error, con consecuencias, con esperanza tranquilas pero generalmente impredecibles.

Copy link

ContributorAuthor

cortizgMay 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link

Contributor

EzequielCasteMay 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yo diría
con consecuencias levemente fáciles, pero generalmente impredecibles.

Copy link

Member

joaquinelioMay 30, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

eehhhmm...
qué significa "levemente fácil". Definitiva y rotundamente y un completo CREO QUE NO :)

Uno pone el parche, potencialmente peligroso. entonces
"easy" acá no es "fácil" sino "suave" ("easy, boy" cuando tranquilizás al perro)
hopefully easy
"consecuencias que, esperamos, sean leves/imperceptibles/no dañinas."
"con suerte, consecuencias leves o nulas" menos literal

take it easy

Copy link

ContributorAuthor

cortizgMay 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

se escucha mejor!

1-js/08-prototypes/04-prototype-methods/article.md OutdatedShow resolvedHide resolved

1-js/08-prototypes/index.mdShow resolvedHide resolved

javascript-translate-bot removed the review needed label

May 25, 2020

Copy link

javascript-translate-bot commentedMay 25, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label

May 25, 2020

revisión 2020-05-29

e8f41e7

Copy link

ContributorAuthor

cortizg commentedMay 30, 2020

/done

javascript-translate-bot added review needed and removed changes requested labels

May 30, 2020

cortizg added2 commits

May 30, 2020 12:59

revision 2020-05-30

ad49226

revision 2020-05-30 2

9d22f63

joaquinelio reviewed

May 30, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@ezzep66
"apruebo"
pero no me animo a "approve"
tengo miedo que haga un merge automático
¿seguimos alimentando el repo? ¿probamos, pongo approve y vemos si el bot hace merge?
porque todavía no sabemos como manejar el repo actual