javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star600

Property flags and descriptors#183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

EzequielCaste merged 13 commits intojavascript-tutorial:masterfromkenliten:master

Jul 1, 2020

Merged

Property flags and descriptors#183

EzequielCaste merged 13 commits intojavascript-tutorial:masterfromkenliten:master

Jul 1, 2020

Conversation

Copy link

Contributor

kenliten commentedMay 12, 2020

No description provided.

Property flags and descriptors

6075c98

javascript-translate-bot added the review needed label

May 12, 2020

javascript-translate-bot requested a review froma team

May 12, 2020 03:16

Copy link

CLAassistant commentedMay 12, 2020•
edited
Loading

All committers have signed the CLA.

iliakan mentioned this pull request

May 12, 2020

Spanish Translation Progress#17

Open

Merge branch 'master' into master

d8b3d1b

EzequielCaste requested changes

Jun 24, 2020

View reviewed changes

Copy link

Contributor

EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hay problemas con el número de las líneas a partir de línea 127. Verificar con artículo original EN

Alguna sugerencia?

1-js/07-object-properties/01-property-descriptors/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot removed the review needed label

Jun 24, 2020

Copy link

javascript-translate-bot commentedJun 24, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label

Jun 24, 2020

vplentinaxand others added3 commits

June 25, 2020 14:52

Update 1-js/07-object-properties/01-property-descriptors/article.md

eed1c43

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>

Update 1-js/07-object-properties/01-property-descriptors/article.md

531b243

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>

Update 1-js/07-object-properties/01-property-descriptors/article.md

52788c2

Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>

Copy link

Contributor

vplentinax commentedJun 25, 2020

/done

vplentinax previously requested changes

Jun 25, 2020

View reviewed changes

Copy link

Contributor

vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Le faltaron partes por traducir. Las estructuras coinciden EN vs ES

1-js/07-object-properties/01-property-descriptors/article.mdShow resolvedHide resolved

Copy link

javascript-translate-bot commentedJun 25, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinax added2 commits

June 30, 2020 13:26

Update 1-js/07-object-properties/01-property-descriptors/article.md

5eea71f

Update 1-js/07-object-properties/01-property-descriptors/article.md

befa1fe

Copy link

Contributor

vplentinax commentedJun 30, 2020

/done

Copy link

Contributor

vplentinax commentedJun 30, 2020

Volver a revisar

vplentinax added the review needed label

Jun 30, 2020

joaquinelio added2 commits

June 30, 2020 20:05

Update article.md

840c9ae

añadido triple grave linea 127

Update article.md

654c618

Editado smart header y contenido  251 - 254

joaquinelio approved these changes

Jun 30, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Edité el archivo directamente, dejo registro:
127 agregado formato gravegravegrave,
no se puede hacer suggest porque el triple tilde lo cierra y borraria la linea
251-254 ??? el smart header es completamente distinto...
dejo en coment el original y también edito directamente por la misma razon del triple tilde.

1-js/07-object-properties/01-property-descriptors/article.md Outdated

		Notable exception: a value of non-configurable, but writable property can be changed.

		The idea of `configurable: false` is to prevent changes to property flags and its deletion, not changes to its value.
		```smart header="Los errores aparecen solo en uso estricto"

Copy link

Member

joaquinelioJun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Original 251-252
___smart header="Los errores aparecen solo en uso estricto"
En el modo no estricto, no aparecen errores al escribir en propiedades de solo lectura y semejantes. Pero la operación no será ejecutada. Las acciones viola-identificadores son silenciadas e ignoradas en modo no estricto.