javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star600

WeakMap and WeakSet#176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

EzequielCaste merged 12 commits intojavascript-tutorial:masterfromvplentinax:weak

Jun 15, 2020

Merged

WeakMap and WeakSet#176

EzequielCaste merged 12 commits intojavascript-tutorial:masterfromvplentinax:weak

Jun 15, 2020

Conversation

Copy link

Contributor

vplentinax commentedMay 10, 2020

No description provided.

javascript-translate-bot added the review needed label

May 10, 2020

javascript-translate-bot requested a review froma team

May 10, 2020 06:22

iliakan mentioned this pull request

May 10, 2020

Spanish Translation Progress#17

Open

WeakMap and WeakSet

01abb36

cortizg reviewed

Jun 9, 2020

View reviewed changes

Copy link

Contributor

cortizg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

discrepo en dejar Array en las traducciones, este review lo dejo como comentario, pero hay unas traducciones pequeñas que se pasaron por alto como "Like this"

1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md

		Otra solución diferente podría ser agregar una propiedad como `message.isRead = true` a un mensaje después de leerlo. Como los objetos de mensajes son administrados por otro código, generalmente se desaconseja, pero podemos usar una propiedad simbólica para evitar conflictos.

		Like this:
		```js

Copy link

Contributor

cortizgJun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Como esto:

1-js/05-data-types/weakmap-weakset/01-recipients-read/task.md


		---

		# Almacenar banderas "no leídas"

Copy link

Contributor

cortizgJun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Mencionaba Joaquin que banderas se deja como flags, tal como hace MDN

1-js/05-data-types/weakmap-weakset/01-recipients-read/task.md

		# Almacenar banderas "no leídas"

		Hay un array de mensajes:

Copy link

Contributor

cortizgJun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

array es arreglo, incluso MDN dice arreglo

1-js/05-data-types/weakmap-weakset/02-recipients-when-read/task.md


		# Almacenar fechas de lectura

		Hay un array semejante al de la actividad anterior [previous task](info:task/recipients-read). La sitación es similar:

Copy link

Contributor

cortizgJun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

array es arreglohttps://developer.mozilla.org/es/docs/Glossary/Arreglos

1-js/05-data-types/weakmap-weakset/02-recipients-when-read/task.md Outdated


		En la tarea anterior solo necesitábamos almacenar el hecho de "sí / no". Ahora necesitamos almacenar la fecha, y solo debe permanecer en la memoria hasta que el mensaje sea recolectado como basura.

		P.D Las fechas se pueden almacenar como objetos de la clase incorporada `Fecha`, que cubriremos más adelante.

Copy link

Contributor

cortizgJun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

la clase incorporada (builtin) se llama Date: OJO

1-js/05-data-types/weakmap-weakset/article.md


		Por lo general, las propiedades de un objeto o elementos de un array u otra estructura de datos se consideran accesibles y se mantienen en la memoria mientras esa estructura de datos permanezca en la memoria.

		Por ejemplo, si colocamos un objeto en un array, mientras el array esté vivo, el objeto también estará vivo, incluso si no hay otras referencias a él.

Copy link

Contributor

cortizgJun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

array es arreglohttps://developer.mozilla.org/es/docs/Glossary/Arreglos

1-js/05-data-types/weakmap-weakset/article.md

		john = null; // sobrescribe la referencia

		!
		// John se almacena dentro del array, por lo que no será recolectado por el recolector de basura

Copy link

Contributor

cortizgJun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

busqueda y reemplazo con editor de texto array por arreglo

1-js/05-data-types/weakmap-weakset/article.mdShow resolvedHide resolved

cortizg suggested changes

Jun 9, 2020

View reviewed changes

Copy link

Contributor

cortizg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

traducciones que pasaron por alto y un typo

1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md OutdatedShow resolvedHide resolved

1-js/05-data-types/weakmap-weakset/02-recipients-when-read/task.md OutdatedShow resolvedHide resolved

1-js/05-data-types/weakmap-weakset/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

Jun 9, 2020

Copy link

javascript-translate-bot commentedJun 9, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinaxand others added4 commits

June 10, 2020 19:28

Update 1-js/05-data-types/weakmap-weakset/article.md

46913d1

Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>

Update 1-js/05-data-types/weakmap-weakset/article.md

50372ba

Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>

Update 1-js/05-data-types/weakmap-weakset/02-recipients-when-read/tas…

114d816

…k.mdCo-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>

Update 1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md

1c9082b

Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>

joaquinelio approved these changes

Jun 14, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Un par de cositas tipo "suggest" nomás.
Abandono la pelea de glosario array. Cambialo o no, then merge sin asco.

1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md OutdatedShow resolvedHide resolved

1-js/05-data-types/weakmap-weakset/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot added needs +1 and removed changes requested labels

Jun 14, 2020

EzequielCasteand others added7 commits

June 15, 2020 18:24

Update 1-js/05-data-types/weakmap-weakset/article.md

7ec5e4b

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/weakmap-weakset/article.md

e8a6054

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/weakmap-weakset/article.md

1fa8c93

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/weakmap-weakset/article.md

af3268f

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/weakmap-weakset/article.md

826a7ef

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/weakmap-weakset/article.md

c66d582

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/05-data-types/weakmap-weakset/01-recipients-read/solution.md

6c6d71a

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

EzequielCaste merged commita4edb73 intojavascript-tutorial:master

Jun 15, 2020

Copy link

javascript-translate-bot commentedJun 15, 2020

Thank you 💖 I updated the Progress Issue#17 🎉 🎉 🎉

Labels

needs +1

5 participants

Movatterモバイル変換

WeakMap and WeakSet#176

WeakMap and WeakSet#176

Uh oh!

Conversation

vplentinax commentedMay 10, 2020

Uh oh!

cortizg left a comment

Choose a reason for hiding this comment

Uh oh!

cortizgJun 9, 2020

Choose a reason for hiding this comment

Uh oh!

cortizgJun 9, 2020

Choose a reason for hiding this comment

Uh oh!

cortizgJun 9, 2020

Choose a reason for hiding this comment

Uh oh!

cortizgJun 9, 2020

Choose a reason for hiding this comment

Uh oh!

cortizgJun 9, 2020

Choose a reason for hiding this comment

Uh oh!

cortizgJun 9, 2020

Choose a reason for hiding this comment

Uh oh!

cortizgJun 9, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cortizg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedJun 9, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedJun 15, 2020

Uh oh!

Uh oh!