javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star601

Strings#126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

joaquinelio merged 9 commits intojavascript-tutorial:masterfromferueda:master

Jun 18, 2020

Merged

Strings#126

joaquinelio merged 9 commits intojavascript-tutorial:masterfromferueda:master

Jun 18, 2020

Conversation

Copy link

Contributor

ferueda commentedDec 6, 2019

String article and tests (tasks and solutions) translated to spanish.

ferueda added4 commits

November 28, 2019 08:15

translating string article to spanish

cecac71

continued translating article Strings

65b4eaa

finished last translation review

10090b8

finished article and tests

1678cc1

javascript-translate-bot added the review needed label

Dec 6, 2019

javascript-translate-bot requested a review froma team

December 6, 2019 23:12

spideep suggested changes

Dec 10, 2019

View reviewed changes

1-js/05-data-types/03-string/2-check-spam/solution.md

		alert( checkSpam("innocent rabbit") );
		alert( checkSpam('compra ViAgRAahora') );
		alert( checkSpam('xxxxx gratis') );
		alert( checkSpam("coneja inocente") );

Copy link

ContributorAuthor

feruedaDec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No entiendo el cambio solicitado aquí.

1-js/05-data-types/03-string/article.md Outdated

		@@ -1,23 +1,23 @@
		# Strings

		In JavaScript,the textual data is stored as strings. There is no separate type for a single character.
		En JavaScript,los datos textuales son almacenados como strings (cadena de caracteres). No hay un tipo de datos separado para caracteres únicos.

Copy link

spideepDec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

'unitarios' en lugar de 'únicos'. Puesto que se refiere a la cantidad de caracteres no a la exclusividad.

javascript-translate-bot removed the review needed label

Dec 10, 2019

Copy link

javascript-translate-bot commentedDec 10, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label

Dec 10, 2019

ferueda commented

Dec 10, 2019

View reviewed changes

1-js/05-data-types/03-string/2-check-spam/solution.md

		alert( checkSpam("innocent rabbit") );
		alert( checkSpam('compra ViAgRAahora') );
		alert( checkSpam('xxxxx gratis') );
		alert( checkSpam("coneja inocente") );

Copy link

ContributorAuthor

feruedaDec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No entiendo el cambio solicitado aquí.

changed únicos for unitarios

c23397a

Copy link

ContributorAuthor

ferueda commentedDec 13, 2019

/done

javascript-translate-bot added review needed and removed changes requested labels

Dec 13, 2019

Copy link

ContributorAuthor

ferueda commentedJan 7, 2020

It looks like no one is reviewing these pull requests from the community. If you need help revewing them I can help as a reviewer.

joaquinelio changed the title~~Strings article translated to spanish~~Strings

Jun 8, 2020

iliakan mentioned this pull request

Jun 8, 2020

Spanish Translation Progress#17

Open

Merge branch 'master' into master

a3dfe10

joaquinelio requested changes

Jun 17, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cambié Un mont+on!!!!!!!!!! Falta ahora:

Restaurar un ejercicio (lo marqué)
79 - Restaurar una tabla y retraducirla.(faltan items y descripciones)
135, 150 - Revisar formato con inglés: el suggest arruina los marckup triple comilla `
VOLVERÉ con un editor bueno

1-js/05-data-types/03-string/1-ucfirst/solution.md OutdatedShow resolvedHide resolved

1-js/05-data-types/03-string/1-ucfirst/task.md OutdatedShow resolvedHide resolved

1-js/05-data-types/03-string/3-truncate/solution.md OutdatedShow resolvedHide resolved

1-js/05-data-types/03-string/3-truncate/task.md OutdatedShow resolvedHide resolved

1-js/05-data-types/03-string/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

Jun 17, 2020

Copy link

javascript-translate-bot commentedJun 17, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

joaquinelio added3 commits

June 17, 2020 06:16

Apply suggestions from code review

1f96e20

37 cambios que me atreví a hacer sin permisotildes, gramática, y err de concepto mas lineas que no habian sido traducidas adrede

Update article.md

10be5cb

Actualización grossa

Update article.md

ed4d11c

ortografía

joaquinelio approved these changes

Jun 18, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed changes requested labels

Jun 18, 2020

joaquinelio merged commitfb3b99c intojavascript-tutorial:master

Jun 18, 2020

Copy link

javascript-translate-bot commentedJun 18, 2020

Thank you 💖 I updated the Progress Issue#17 🎉 🎉 🎉

Labels

needs +1

5 participants

Movatterモバイル変換

Strings#126

Strings#126

Uh oh!

Conversation

ferueda commentedDec 6, 2019

Uh oh!

feruedaDec 10, 2019

Choose a reason for hiding this comment

Uh oh!

spideepDec 10, 2019

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commentedDec 10, 2019

Uh oh!

feruedaDec 10, 2019

Choose a reason for hiding this comment

Uh oh!

ferueda commentedDec 13, 2019

Uh oh!

ferueda commentedJan 7, 2020

Uh oh!

joaquinelio left a comment• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedJun 17, 2020

Uh oh!

javascript-translate-bot commentedJun 18, 2020

Uh oh!

Uh oh!

joaquinelio left a comment•
edited
Loading