javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star601

Symbol type#115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

mariabp wants to merge11 commits intojavascript-tutorial:masterfrommariabp:spanish-symbol

Closed

Symbol type#115

mariabp wants to merge11 commits intojavascript-tutorial:masterfrommariabp:spanish-symbol

Conversation

Copy link

mariabp commentedOct 22, 2019

Translation to spanish ready to review :)

First translation

6f952dc

javascript-translate-bot added the review needed label

Oct 22, 2019

javascript-translate-bot requested a review froma team

October 22, 2019 15:33

Copy link

CLAassistant commentedOct 22, 2019•
edited
Loading

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign ourContributor License Agreement before we can accept your contribution.
2 out of3 committers have signed the CLA.

✅ mariabp
✅ vplentinax
❌ Developer

Developer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let usrecheck it.}

lizzie136 requested changes

Oct 29, 2019

View reviewed changes

Copy link

Member

lizzie136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hola@mariabp
esta super genial la traducción, solo hay un pequeño detalle,
en todas las declaraciones le agregaste un espacio extra.
Por ejemplo:
let id = Symbol("id"); , debería serlet id = Symbol("id"); (le quité un espacio entre ellet y elid

javascript-translate-bot added changes requested and removed review needed labels

Oct 29, 2019

Copy link

javascript-translate-bot commentedOct 29, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

mariabpand others added2 commits

November 1, 2019 11:35

Update article.md

de0b438

Listo! Ya eliminé los espacios extras, que raro que los puse 🤔 . Me dices que te parece :)

Deleted extra space between declaration and name of variable

0a786f0

Copy link

Author

mariabp commentedNov 8, 2019•
edited
Loading

Done

lizzie136 added review needed and removed changes requested labels

Nov 15, 2019

lizzie136 self-requested a review

November 15, 2019 15:50

lizzie136 approved these changes

Nov 15, 2019

View reviewed changes

Copy link

Member

lizzie136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM🚀

javascript-translate-bot added needs +1 and removed review needed labels

Nov 15, 2019

lizzie136 requested review fromcaballerof andtscandalitta

November 15, 2019 15:51

tscandalitta reviewed

Nov 20, 2019

View reviewed changes

1-js/04-object-basics/03-symbol/article.md Outdated

		let id = Symbol("id");
		```

		Symbolsare guaranteed to be unique. Even if we create many symbols with the same description, they are different values. The description is just a label that doesn't affect anything.
		LosSymbolsestán garantizados a ser únicos. Aunque declaremos varios Symbols con la misma descripción éstos tendrán valores distintos. La descripción es solamente una etiqueta que no afecta nada más.

Copy link

Collaborator

tscandalittaNov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"Se garantiza que los símbolos son únicos" me parece que suena más natural, lo dejo a tu criterio.
"Aunque declaremos varios Symbols con la misma descripción, éstos ..."

Copy link

Author

mariabpNov 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Estoy de acuerdo contigo!

tscandalitta reviewed

Nov 20, 2019

View reviewed changes

1-js/04-object-basics/03-symbol/article.md Outdated


		````warn header="Symbols don't auto-convert to a string"
		Most values in JavaScript support implicit conversion to a string. For instance, we can `alert` almost any value, and it will work. Symbols are special. They don't auto-convert.
		````warn header="Symbols no se auto convierten a String"

Copy link

Collaborator

tscandalittaNov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

auto-convierten, para ser consistentes

tscandalitta reviewed

Nov 20, 2019

View reviewed changes

1-js/04-object-basics/03-symbol/article.md Outdated


		Symbolsallow us to create "hidden" properties of an object, that no other part of code can occasionally access or overwrite.
		LosSymbolsnos permiten crear propiedades "ocultas" en un objeto, las cuales ninguna otra parte del código puede accesar ni sobre-escribir.

Copy link

Collaborator

tscandalittaNov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Los Symbols nos permiten crear propiedades "ocultas" en un objeto,a las cuales ninguna otra parte del código puedeacceder ni sobre-escribir.

Copy link

Collaborator

tscandalitta commentedNov 20, 2019

No se debe traducir los nombres de las variables, por ejemplo de "user" a "usuario"

Don't translate variables, classes, identifiers.

vplentinax changed the title~~First translation~~Symbol type

Jun 7, 2020

iliakan mentioned this pull request

Jun 7, 2020

Spanish Translation Progress#17

Open

vplentinax requested review fromjoaquinelio andEzequielCaste

June 7, 2020 19:21

Copy link

Contributor

vplentinax commentedJun 7, 2020

Revisenlo para yo agregar los cambios y no tener que volverlos a revisar una vez arregle el conflicto de estructura.

joaquinelio requested changes

Jun 8, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@ezzep66
te lo paso porque puse varias cosas

1-js/04-object-basics/03-symbol/article.md OutdatedShow resolvedHide resolved

Copy link

javascript-translate-bot commentedJun 8, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label

Jun 8, 2020

vplentinaxand others added5 commits

June 10, 2020 00:54

Update 1-js/04-object-basics/03-symbol/article.md

239004b

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/03-symbol/article.md

969795a

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/03-symbol/article.md

82a0bb0

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/03-symbol/article.md

68d693c

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/03-symbol/article.md

505e32b

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Copy link

Contributor

vplentinax commentedJun 10, 2020

/done

vplentinaxand others added3 commits

June 10, 2020 19:34

Update 1-js/04-object-basics/03-symbol/article.md

5015fc3

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/03-symbol/article.md

6ba4d07

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 1-js/04-object-basics/03-symbol/article.md

63349ea

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

vplentinax mentioned this pull request

Jun 13, 2020

Symbol type#252

Merged

vplentinax closed this

Jun 13, 2020

Labels

changes requested needs +1

7 participants

Movatterモバイル変換

Symbol type#115

Symbol type#115

Uh oh!

Conversation

mariabp commentedOct 22, 2019

Uh oh!

CLAassistant commentedOct 22, 2019• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

lizzie136 left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commentedOct 29, 2019

Uh oh!

mariabp commentedNov 8, 2019• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

lizzie136 left a comment

Choose a reason for hiding this comment

Uh oh!

tscandalittaNov 20, 2019

Choose a reason for hiding this comment

Uh oh!

mariabpNov 24, 2019

Choose a reason for hiding this comment

Uh oh!

tscandalittaNov 20, 2019

Choose a reason for hiding this comment

Uh oh!

tscandalittaNov 20, 2019

Choose a reason for hiding this comment

Uh oh!

tscandalitta commentedNov 20, 2019

Uh oh!

vplentinax commentedJun 7, 2020

Uh oh!

joaquinelio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commentedJun 8, 2020

Uh oh!

vplentinax commentedJun 10, 2020

Uh oh!

Uh oh!

CLAassistant commentedOct 22, 2019•
edited
Loading

mariabp commentedNov 8, 2019•
edited
Loading