javascript-tutorial/es.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork230
Star608

Ninja code#109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

joaquinelio merged 19 commits intojavascript-tutorial:masterfromSjesc:ninja-code-2

Jun 7, 2020

Merged

Ninja code#109

joaquinelio merged 19 commits intojavascript-tutorial:masterfromSjesc:ninja-code-2

Jun 7, 2020

Conversation

Copy link

Contributor

Sjesc commentedOct 4, 2019

No description provided.

Sjesc added3 commits

October 2, 2019 22:53

Update fork (#3)

768f2ab

Update fork

Traducir articulo ninja code

757bd6b

terminar traduccion del articulo

d31b843

javascript-translate-bot added the review needed label

Oct 4, 2019

javascript-translate-bot requested a review froma team

October 4, 2019 23:14

iliakan mentioned this pull request

Oct 4, 2019

Spanish Translation Progress#17

Open

EzequielCaste requested changes

May 30, 2020

View reviewed changes

Copy link

Contributor

EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

corregir

1-js/03-code-quality/04-ninja-code/article.md OutdatedShow resolvedHide resolved

1-js/03-code-quality/04-ninja-code/article.md Outdated

		A fellow programmer who wants to work with`elem` in the second half of the function will be surprised... Only during the debugging, after examining the code they will find out that they're working with a clone!

		Seen in code regularly. Deadly effective even against an experienced ninja.
		Un compañero de programación que quiera trabajar con`elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon.

Copy link

Contributor

EzequielCasteMay 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	Uncompañero de programación que quiera trabajar con`elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon.
	Uncolega programador que quiera trabajar con`elem` en la segunda mitad de la función será sorprendido... Solo durante la depuración, después de examinar el código encontrara que está trabajando con un clon.

1-js/03-code-quality/04-ninja-code/article.md OutdatedShow resolvedHide resolved

javascript-translate-bot added changes requested and removed review needed labels

May 30, 2020

Copy link

javascript-translate-bot commentedMay 30, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCaste requested a review fromjoaquinelio

May 30, 2020 20:16

joaquinelio requested changes

May 30, 2020

View reviewed changes

Copy link

Member

joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Se ve lindo.
@ezzep66 , ¿seguimos con doble revisión?
Lo hice encima de la tuya así apenas se corrige la podés subir.
Si pensás que no hacen falta, disculpas.

La gramática no es el tema más importante en JS. Ni siquiera para la virtual machine jeje

1-js/03-code-quality/04-ninja-code/article.md OutdatedShow resolvedHide resolved

1-js/03-code-quality/04-ninja-code/article.mdShow resolvedHide resolved

1-js/03-code-quality/04-ninja-code/article.md OutdatedShow resolvedHide resolved

Copy link

javascript-translate-bot commentedMay 30, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Copy link

Contributor

EzequielCaste commentedJun 1, 2020

qué se hace si@Sjesc no responde?

podemos nosotros maintainers corregir?

Merge branch 'master' into ninja-code-2

2c30d17

Copy link

Contributor

vplentinax commentedJun 5, 2020

Si, tenemos que corregir@ezzep66 @joaquinelio

vplentinaxand others added12 commits

June 6, 2020 00:44