The catastrophic backtracking solution described where atomic groups are emulated using lookahead and backreferences is useful but can be tricky to use and error prone (e.g. when quantifying the result, or in longer patterns that rely on multiple atomic groups). So this adds a link to an easy to use solution that enables the direct use of atomic groups via(?>…) in native JS regexes.

javascript-translate-bot added the review neededReview needed, please approve or request changes label

Jun 5, 2024

javascript-translate-bot requested a review froma team

June 5, 2024 13:20

Copy link

CLAassistant commentedJun 5, 2024•
edited
Loading

All committers have signed the CLA.

CyberAnilpatil approved these changes

Jun 6, 2024

View reviewed changes

javascript-translate-bot added needs +1One more review needed and removed review neededReview needed, please approve or request changes labels

Jun 6, 2024

slevithan force-pushed thepatch-1 branch fromdad802a to1bbc66eCompare

June 8, 2024 11:34

slevithan force-pushed thepatch-1 branch from1bbc66e to751946dCompare

June 18, 2024 12:55

Copy link

Author

slevithan commentedJun 18, 2024

I updated the PR to make some additional tweaks:

Atomic groups don't capture, so I changed "atomic capturing groups" to "atomic groups" (their correct name).
The emulation trick (with a backreference to a capturing group inside a lookahead) emulates an atomic group, not a possessive quantifier, so I corrected this. This distinction is subtle since possessive quantifiers are sugar for some common uses of atomic groups, but it is important. For example, the lookahead/capture trick accurately emulates the behavior of an atomic group like(?>…|…) which is not followed by a quantifier at all.

slevithan changed the title~~Add a solution for that enables the direct use of atomic groups~~Add a solution that enables the direct use of atomic groups

Jul 2, 2024

smith558 requested a review fromCyberAnilpatil

July 10, 2024 15:15

smith558 self-assigned this

Jul 10, 2024

smith558 requested review fromAlexandre887 and removed request forCyberAnilpatil

July 10, 2024 15:16

Add a solution that enables the direct use of atomic groups

dd86e7e

The solution described where atomic groups are emulated using lookahead and backreferences is useful but can be tricky to use and error prone (e.g. when quantifying the result, or in longer patterns that rely on multiple atomic groups). So this adds a link to an easy to use solution that enables the direct use of atomic groups via `(?>…)` in native JS regexes.

slevithan force-pushed thepatch-1 branch from751946d todd86e7eCompare

August 16, 2024 16:03

Copy link

Author

slevithan commentedAug 16, 2024

Ping@Alexandre887 for review. This PR makes this (already quite informative) article even better for readers.

Copy link

Author

slevithan commentedMar 8, 2025

Hey@smith558, any problem with landing this PR as is?

Copy link

Member

Alexandre887 commentedMar 9, 2025

Hey@slevithan, just want to make it clear that PRs are reviewed by volunteers here, so there is no strict timetable for when a particular PR will be merged or anything like that — it's directly dependent on the availability of free time and willingness to review a particular PR. So if there is no response for a long time, it doesn't mean that your PR has been forgotten about, or that it has some flaws (otherwise someone would have said you about it). Thanks for your patience.