Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix link to ECMA-262 specification#3691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sneeed wants to merge2 commits intojavascript-tutorial:master
base:master
Choose a base branch
Loading
fromsneeed:patch-1

Conversation

sneeed
Copy link
Contributor

old link was broken

@javascript-translate-botjavascript-translate-bot added the review neededReview needed, please approve or request changes labelMay 9, 2024
@javascript-translate-botjavascript-translate-bot requested a review froma teamMay 9, 2024 13:41
@CLAassistant
Copy link

CLAassistant commentedMay 9, 2024•
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link

@AfirestrikerAfirestriker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@javascript-translate-botjavascript-translate-bot added needs +1One more review needed and removed review neededReview needed, please approve or request changes labelsMay 14, 2024
@slevithan
Copy link

This PR is incorrect. It arbitrarily links to the ancient v5.1 of the spec.

The current link is fine. It just redirects tohttps://ecma-international.org/publications-and-standards/standards/ecma-262/

Three options:

  1. Keep the current link, which redirects.
  2. Update to the new URL (redirect target).
  3. Usehttps://tc39.es/ecma262/ which is always the most up-to-date ECMAScript spec (including any finished proposals).

Any of the above seem okay, but not accepting this PR as is.

@@ -5,7 +5,7 @@ This book is a *tutorial*. It aims to help you gradually learn the language. But

## Specification

[The ECMA-262 specification](https://www.ecma-international.org/publications/standards/Ecma-262.htm) contains the most in-depth, detailed and formalized information about JavaScript. It defines the language.
[The ECMA-262 specification](https://262.ecma-international.org/5.1/) contains the most in-depth, detailed and formalized information about JavaScript. It defines the language.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should link to the latest standard, not v5.1 from 2011.

@javascript-translate-botjavascript-translate-bot added the changes requestedWaiting for changes and /done from PR author labelJun 18, 2024
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@sneeed
Copy link
ContributorAuthor

/done

Thanks for the feedback.

I think your option 3 would be best and changed it accordingly.

shallow-beach reacted with thumbs up emoji

@javascript-translate-botjavascript-translate-bot added review neededReview needed, please approve or request changes and removed changes requestedWaiting for changes and /done from PR author labelsJun 18, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@slevithanslevithanslevithan requested changes

@AfirestrikerAfirestrikerAfirestriker approved these changes

Assignees
No one assigned
Labels
needs +1One more review neededreview neededReview needed, please approve or request changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@sneeed@CLAassistant@slevithan@javascript-translate-bot@Afirestriker
[8]ページ先頭
©2009-2025 Movatter.jp