javascript-tutorial/en.javascript.infoPublic

NotificationsYou must be signed in to change notification settings
Fork3.9k
Star24.4k

Scheduling: setTimeout and setInterval#3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

bogdanbacosca wants to merge7 commits intojavascript-tutorial:master

base:master

Choose a base branch

frombogdanbacosca:timeout

Open

Scheduling: setTimeout and setInterval#3423

bogdanbacosca wants to merge7 commits intojavascript-tutorial:masterfrombogdanbacosca:timeout

Conversation

Copy link

Contributor

bogdanbacosca commentedApr 2, 2023

lines 101, 211, 259, 261, 280, 282 and 284 - improvement suggestions
line 130 - grammar fix

bogdanbacosca added7 commits

March 26, 2023 15:22

line 101

d801b5d

line 130

13264dc

line 211

ec51052

line 259

0dd79b2

line 261

6f3cda0

line 280

feab961

lines 282 and 284

33d655f

shallow-beach suggested changes

Aug 24, 2024

View reviewed changes

1-js/06-advanced-functions/08-settimeout-setinterval/article.md

		@@ -127,7 +127,7 @@ setTimeout(() => { clearInterval(timerId); alert('stop'); }, 5000);
		```

		```smart header="Time goes on while `alert` is shown"
		In most browsers, including Chrome and Firefox the internal timer continues "ticking" while showing `alert/confirm/prompt`.
		In most browsers including Chrome and Firefox, the internal timer continues "ticking" while showing `alert/confirm/prompt`.

Copy link

Contributor

shallow-beachAug 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

IMO should have both:

In most browsers, including Chrome and Firefox, the internal timer continues "ticking" while showingalert/confirm/prompt.

1-js/06-advanced-functions/08-settimeout-setinterval/article.md

		@@ -208,7 +208,7 @@ Did you notice?

		That's normal, because the time taken by `func`'s execution "consumes" a part of the interval.

		It is possible that `func`'s executionturns outto be longer than we expected andtakes more than 100ms.
		It is possible that `func`'s execution to be longer than we expected andtake more than 100ms.

Copy link

Contributor

shallow-beachAug 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

disagree, leave as original

1-js/06-advanced-functions/08-settimeout-setinterval/article.md

		@@ -256,9 +256,9 @@ The first line "puts the call into calendar after 0ms". But the scheduler will o
		There are also advanced browser-related use cases of zero-delay timeout, that we'll discuss in the chapter <info:event-loop>.

		````smart header="Zero delay is in fact not zero (in a browser)"
		In the browser, there's a limitationof how often nested timers can run. The [HTML Living Standard](https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#timers) says: "after five nested timers, the interval is forced to be at least 4 milliseconds.".
		In the browser, there's a limitationfor how often nested timers can run. The [HTML Living Standard](https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#timers) says: "after five nested timers, the interval is forced to be at least 4 milliseconds.".