- Notifications
You must be signed in to change notification settings - Fork3.9k
tiny changes: spelling and consistency#3416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Spelling:`optimzed` -> `optimized`Consistency: `Import *` -> `Import "*"` For consistency with `Import "as" and `Export "as"`.Also -- as-is it looks like `Import *` is just `Import` with a footnote. It had me confused for several minutes.NB: This shouldn't affect links, since neither `*` nor quotes are reflected in the link fragment. The URL is simply `/import-export#import` either way.
CLAassistant commentedMar 27, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
shallow-beach left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thank you for contributions!
(vote to close)
| @@ -63,7 +63,7 @@ export {sayHi, sayBye}; // a list of exported variables | |||
| ...Or, technically we could put `export` above functions as well. | |||
| ## Import* | |||
| ## Import"*" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
disagree. all footnotes are signified with(*), and this diverges from typical JS syntax
| @@ -99,7 +99,7 @@ Well, there are few reasons. | |||
| ```smart header="Don't be afraid to import too much" | |||
| Modern build tools, such as [webpack](https://webpack.js.org/) and others, bundle modules together and optimize them to speedup loading. They also removed unused imports. | |||
| For instance, if you `import * as library` from a huge code library, and then use only few methods, then unused ones [will not be included](https://github.com/webpack/webpack/tree/main/examples/harmony-unused#examplejs) into theoptimzed bundle. | |||
| For instance, if you `import * as library` from a huge code library, and then use only few methods, then unused ones [will not be included](https://github.com/webpack/webpack/tree/main/examples/harmony-unused#examplejs) into theoptimized bundle. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
duplicate of#3413
Uh oh!
There was an error while loading.Please reload this page.
Spelling:
optimzed->optimizedConsistency:
Import *->Import "*"For consistency with
Import "as"andExport "as". Also -- as-is it looks likeImport *is justImportwith a footnote. It had me confused for several minutes.NB: This shouldn't affect links, since neither
*nor quotes are reflected in the link fragment. The URL is simply/import-export#importeither way.