- Notifications
You must be signed in to change notification settings - Fork3.9k
Fix minor grammatical errors#3410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
kristenmazza wants to merge2 commits intojavascript-tutorial:masterChoose a base branch fromkristenmazza:fix-grammar-errors
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes fromall commits
Commits
Show all changes
2 commits Select commitHold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
14 changes: 7 additions & 7 deletions1-js/07-object-properties/02-property-accessors/article.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -34,7 +34,7 @@ let user = { | ||
}; | ||
``` | ||
Now we want to add a `fullName` property,which should be `"John Smith"`. Of course, we don't want to copy-paste existing information, so we can implement it as an accessor: | ||
```js run | ||
let user = { | ||
@@ -104,10 +104,10 @@ For accessor properties, there is no `value` or `writable`, but instead there ar | ||
That is, an accessor descriptor may have: | ||
- **`get`** -- a function without arguments that works when a property is read | ||
- **`set`** -- a function with one argument that is called when the property is set | ||
- **`enumerable`** -- same as for data properties | ||
- **`configurable`** -- same as for data properties | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. might suggest dropping punctuation at end of bullets as well:
| ||
For instance, to create an accessor `fullName` with `defineProperty`, we can pass a descriptor with `get` and `set`: | ||
@@ -185,7 +185,7 @@ Technically, external code is able to access the name directly by using `user._n | ||
## Using for compatibility | ||
One of the great uses of accessors is that they allowusto take control over a "regular" data property at any moment by replacing it with a getter and a setter andtweaking its behavior. | ||
Imagine we started implementing user objects using data properties `name` and `age`: | ||
@@ -241,4 +241,4 @@ alert( john.birthday ); // birthday is available | ||
alert( john.age ); // ...as well as the age | ||
``` | ||
Now the old code works too, and we've got a nice additional property. |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.